linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] crypto: chcr - checking for IS_ERR() instead of NULL
@ 2016-12-01 20:49 Dan Carpenter
  2016-12-02  5:59 ` Harsh Jain
  2016-12-07 12:07 ` Herbert Xu
  0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-12-01 20:49 UTC (permalink / raw)
  To: Herbert Xu
  Cc: David S. Miller, Harsh Jain, Jitendra Lulla, Atul Gupta,
	Hariprasad Shenai, Wei Yongjun, linux-crypto, kernel-janitors

The create_hash_wr() function never returns error pointers.  It returns
NULL on error.

Fixes: 358961d1cd1e ("crypto: chcr - Added new structure chcr_wr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index 32361dd..2ed1e24 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -958,9 +958,8 @@ static int chcr_ahash_update(struct ahash_request *req)
 	req_ctx->result = 0;
 	req_ctx->data_len += params.sg_len + params.bfr_len;
 	skb = create_hash_wr(req, &params);
-
-	if (IS_ERR(skb))
-		return PTR_ERR(skb);
+	if (!skb)
+		return -ENOMEM;
 
 	if (remainder) {
 		u8 *temp;
@@ -1023,8 +1022,8 @@ static int chcr_ahash_final(struct ahash_request *req)
 		params.more = 0;
 	}
 	skb = create_hash_wr(req, &params);
-	if (IS_ERR(skb))
-		return PTR_ERR(skb);
+	if (!skb)
+		return -ENOMEM;
 
 	skb->dev = u_ctx->lldi.ports[0];
 	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
@@ -1074,8 +1073,8 @@ static int chcr_ahash_finup(struct ahash_request *req)
 	}
 
 	skb = create_hash_wr(req, &params);
-	if (IS_ERR(skb))
-		return PTR_ERR(skb);
+	if (!skb)
+		return -ENOMEM;
 
 	skb->dev = u_ctx->lldi.ports[0];
 	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
@@ -1125,8 +1124,8 @@ static int chcr_ahash_digest(struct ahash_request *req)
 	}
 
 	skb = create_hash_wr(req, &params);
-	if (IS_ERR(skb))
-		return PTR_ERR(skb);
+	if (!skb)
+		return -ENOMEM;
 
 	skb->dev = u_ctx->lldi.ports[0];
 	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [patch] crypto: chcr - checking for IS_ERR() instead of NULL
  2016-12-01 20:49 [patch] crypto: chcr - checking for IS_ERR() instead of NULL Dan Carpenter
@ 2016-12-02  5:59 ` Harsh Jain
  2016-12-02  6:12   ` Harsh Jain
  2016-12-07 12:07 ` Herbert Xu
  1 sibling, 1 reply; 4+ messages in thread
From: Harsh Jain @ 2016-12-02  5:59 UTC (permalink / raw)
  To: Dan Carpenter, Herbert Xu
  Cc: David S. Miller, Jitendra Lulla, Atul Gupta, Hariprasad Shenai,
	Wei Yongjun, linux-crypto, kernel-janitors



On 02-12-2016 02:19, Dan Carpenter wrote:
> The create_hash_wr() function never returns error pointers.  It returns
> NULL on error.
Will fix the same, Thanks
>
> Fixes: 358961d1cd1e ("crypto: chcr - Added new structure chcr_wr")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
> index 32361dd..2ed1e24 100644
> --- a/drivers/crypto/chelsio/chcr_algo.c
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -958,9 +958,8 @@ static int chcr_ahash_update(struct ahash_request *req)
>  	req_ctx->result = 0;
>  	req_ctx->data_len += params.sg_len + params.bfr_len;
>  	skb = create_hash_wr(req, &params);
> -
> -	if (IS_ERR(skb))
> -		return PTR_ERR(skb);
> +	if (!skb)
> +		return -ENOMEM;
>  
>  	if (remainder) {
>  		u8 *temp;
> @@ -1023,8 +1022,8 @@ static int chcr_ahash_final(struct ahash_request *req)
>  		params.more = 0;
>  	}
>  	skb = create_hash_wr(req, &params);
> -	if (IS_ERR(skb))
> -		return PTR_ERR(skb);
> +	if (!skb)
> +		return -ENOMEM;
>  
>  	skb->dev = u_ctx->lldi.ports[0];
>  	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
> @@ -1074,8 +1073,8 @@ static int chcr_ahash_finup(struct ahash_request *req)
>  	}
>  
>  	skb = create_hash_wr(req, &params);
> -	if (IS_ERR(skb))
> -		return PTR_ERR(skb);
> +	if (!skb)
> +		return -ENOMEM;
>  
>  	skb->dev = u_ctx->lldi.ports[0];
>  	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
> @@ -1125,8 +1124,8 @@ static int chcr_ahash_digest(struct ahash_request *req)
>  	}
>  
>  	skb = create_hash_wr(req, &params);
> -	if (IS_ERR(skb))
> -		return PTR_ERR(skb);
> +	if (!skb)
> +		return -ENOMEM;
>  
>  	skb->dev = u_ctx->lldi.ports[0];
>  	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [patch] crypto: chcr - checking for IS_ERR() instead of NULL
  2016-12-02  5:59 ` Harsh Jain
@ 2016-12-02  6:12   ` Harsh Jain
  0 siblings, 0 replies; 4+ messages in thread
From: Harsh Jain @ 2016-12-02  6:12 UTC (permalink / raw)
  To: Dan Carpenter, Herbert Xu
  Cc: David S. Miller, Jitendra Lulla, Atul Gupta, Hariprasad Shenai,
	Wei Yongjun, linux-crypto, kernel-janitors



On 02-12-2016 11:29, Harsh Jain wrote:
>
> On 02-12-2016 02:19, Dan Carpenter wrote:
>> The create_hash_wr() function never returns error pointers.  It returns
>> NULL on error.
> Will fix the same, Thanks
It's a patch mail not bug reporting!  Sorry for confusion. You have already fixed it. Thanks.
>> Fixes: 358961d1cd1e ("crypto: chcr - Added new structure chcr_wr")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
>> index 32361dd..2ed1e24 100644
>> --- a/drivers/crypto/chelsio/chcr_algo.c
>> +++ b/drivers/crypto/chelsio/chcr_algo.c
>> @@ -958,9 +958,8 @@ static int chcr_ahash_update(struct ahash_request *req)
>>  	req_ctx->result = 0;
>>  	req_ctx->data_len += params.sg_len + params.bfr_len;
>>  	skb = create_hash_wr(req, &params);
>> -
>> -	if (IS_ERR(skb))
>> -		return PTR_ERR(skb);
>> +	if (!skb)
>> +		return -ENOMEM;
>>  
>>  	if (remainder) {
>>  		u8 *temp;
>> @@ -1023,8 +1022,8 @@ static int chcr_ahash_final(struct ahash_request *req)
>>  		params.more = 0;
>>  	}
>>  	skb = create_hash_wr(req, &params);
>> -	if (IS_ERR(skb))
>> -		return PTR_ERR(skb);
>> +	if (!skb)
>> +		return -ENOMEM;
>>  
>>  	skb->dev = u_ctx->lldi.ports[0];
>>  	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
>> @@ -1074,8 +1073,8 @@ static int chcr_ahash_finup(struct ahash_request *req)
>>  	}
>>  
>>  	skb = create_hash_wr(req, &params);
>> -	if (IS_ERR(skb))
>> -		return PTR_ERR(skb);
>> +	if (!skb)
>> +		return -ENOMEM;
>>  
>>  	skb->dev = u_ctx->lldi.ports[0];
>>  	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
>> @@ -1125,8 +1124,8 @@ static int chcr_ahash_digest(struct ahash_request *req)
>>  	}
>>  
>>  	skb = create_hash_wr(req, &params);
>> -	if (IS_ERR(skb))
>> -		return PTR_ERR(skb);
>> +	if (!skb)
>> +		return -ENOMEM;
>>  
>>  	skb->dev = u_ctx->lldi.ports[0];
>>  	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [patch] crypto: chcr - checking for IS_ERR() instead of NULL
  2016-12-01 20:49 [patch] crypto: chcr - checking for IS_ERR() instead of NULL Dan Carpenter
  2016-12-02  5:59 ` Harsh Jain
@ 2016-12-07 12:07 ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2016-12-07 12:07 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: David S. Miller, Harsh Jain, Jitendra Lulla, Atul Gupta,
	Hariprasad Shenai, Wei Yongjun, linux-crypto, kernel-janitors

On Thu, Dec 01, 2016 at 11:49:37PM +0300, Dan Carpenter wrote:
> The create_hash_wr() function never returns error pointers.  It returns
> NULL on error.
> 
> Fixes: 358961d1cd1e ("crypto: chcr - Added new structure chcr_wr")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-07 12:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-01 20:49 [patch] crypto: chcr - checking for IS_ERR() instead of NULL Dan Carpenter
2016-12-02  5:59 ` Harsh Jain
2016-12-02  6:12   ` Harsh Jain
2016-12-07 12:07 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).