From: Greg KH <gregkh@linuxfoundation.org>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: thomas.lendacky@amd.com, herbert@gondor.apana.org.au,
arnd@arndb.de, lambert.quentin@gmail.com, gary.hook@amd.com,
linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr,
weiyongjun1@huawei.com, linux-crypto@vger.kernel.org,
umgwanakikbuti@gmail.com
Subject: Re: [PATCH 2/2] misc: amd-sp: introduce the AMD Secure Processor device
Date: Thu, 19 Jan 2017 19:22:34 +0100 [thread overview]
Message-ID: <20170119182234.GC30851@kroah.com> (raw)
In-Reply-To: <148484929157.30852.14374439914599162367.stgit@brijesh-build-machine>
On Thu, Jan 19, 2017 at 01:08:11PM -0500, Brijesh Singh wrote:
> The CCP device is part of the AMD Secure Processor. In order to expand the
> usage of the AMD Secure Processor, create a framework that allows functional
> components of the AMD Secure Processor to be initialized and handled
> appropriately.
What do you mean by "framework"? What is this for? Who is going to use
it? Don't add framework that is not ever used, otherwise we will just
delete it.
>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/Kconfig | 1
> drivers/misc/amd-sp/Kconfig | 16 +-
> drivers/misc/amd-sp/Makefile | 11 +
> drivers/misc/amd-sp/ccp-dev-v3.c | 86 +++++-----
> drivers/misc/amd-sp/ccp-dev-v5.c | 72 ++++----
> drivers/misc/amd-sp/ccp-dev.c | 137 +++++++++-------
> drivers/misc/amd-sp/ccp-dev.h | 35 ----
> drivers/misc/amd-sp/sp-dev.c | 309 +++++++++++++++++++++++++++++++++++
> drivers/misc/amd-sp/sp-dev.h | 141 ++++++++++++++++
> drivers/misc/amd-sp/sp-pci.c | 325 +++++++++++++++++++++++++++++++++++++
> drivers/misc/amd-sp/sp-platform.c | 269 +++++++++++++++++++++++++++++++
> 11 files changed, 1225 insertions(+), 177 deletions(-)
> create mode 100644 drivers/misc/amd-sp/sp-dev.c
> create mode 100644 drivers/misc/amd-sp/sp-dev.h
> create mode 100644 drivers/misc/amd-sp/sp-pci.c
> create mode 100644 drivers/misc/amd-sp/sp-platform.c
This patch makes no sense, you need to break it up into "do one logical
thing", as that is NOT what is happening here. It's impossible to
review as-is, sorry.
greg k-h
next prev parent reply other threads:[~2017-01-19 18:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:07 [PATCH 0/2] Introduce AMD Secure Processor device Brijesh Singh
2017-01-19 18:08 ` [PATCH 1/2] crypto: move CCP device driver to misc Brijesh Singh
2017-01-19 18:18 ` Greg KH
2017-01-19 19:10 ` Brijesh Singh
2017-01-20 16:33 ` kbuild test robot
2017-01-19 18:08 ` [PATCH 2/2] misc: amd-sp: introduce the AMD Secure Processor device Brijesh Singh
2017-01-19 18:22 ` Greg KH [this message]
2017-01-20 16:20 ` kbuild test robot
2017-01-20 19:51 ` kbuild test robot
2017-01-19 18:21 ` [PATCH 0/2] Introduce " Greg KH
2017-01-19 20:03 ` Brijesh Singh
2017-01-20 8:45 ` Greg KH
2017-01-20 15:40 ` Brijesh Singh
2017-01-20 17:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119182234.GC30851@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Julia.Lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=brijesh.singh@amd.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=lambert.quentin@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=umgwanakikbuti@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox