From: Nicholas Mc Guire <der.herr@hofr.at>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: arm/aes-ce: assign err return conditionally
Date: Sat, 11 Feb 2017 10:15:43 +0000 [thread overview]
Message-ID: <20170211101543.GC13432@osadl.at> (raw)
In-Reply-To: <20170211093946.GA749@gondor.apana.org.au>
On Sat, Feb 11, 2017 at 05:39:46PM +0800, Herbert Xu wrote:
> On Wed, Feb 08, 2017 at 02:36:19PM +0100, Nicholas Mc Guire wrote:
> > As the err value is not used unless there was an error it can be assigned
> > conditionally here.
> >
> > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
>
> This patch just adds noise to the commit history. So I'm not going
> to apply it.
ok - I was not sure about how sensible this sort of changes are
either - will drop those code-to-object refactoring experiments
then again.
thx!
hofrat
prev parent reply other threads:[~2017-02-11 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 13:36 [PATCH] crypto: arm/aes-ce: assign err return conditionally Nicholas Mc Guire
2017-02-11 9:39 ` Herbert Xu
2017-02-11 10:15 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211101543.GC13432@osadl.at \
--to=der.herr@hofr.at \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox