* [bug report] crypto: cavium - Add the Virtual Function driver for CPT
@ 2017-02-15 8:39 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-02-15 8:39 UTC (permalink / raw)
To: george.cherian; +Cc: linux-crypto
Hello George Cherian,
This is a semi-automatic email about new static checker warnings.
The patch c694b233295b: "crypto: cavium - Add the Virtual Function
driver for CPT" from Feb 7, 2017, leads to the following Smatch
complaint:
drivers/crypto/cavium/cpt/cptvf_reqmanager.c:333 do_post_process()
warn: variable dereferenced before check 'cptvf' (see line 331)
drivers/crypto/cavium/cpt/cptvf_reqmanager.c
330 {
331 struct pci_dev *pdev = cptvf->pdev;
^^^^^^^^^^^
Dereference.
332
333 if (!info || !cptvf) {
^^^^^
Check is too late.
334 dev_err(&pdev->dev, "Input params are incorrect for post processing\n");
335 return;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* [bug report] crypto: cavium - Add the Virtual Function driver for CPT
@ 2017-02-16 20:18 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-02-16 20:18 UTC (permalink / raw)
To: george.cherian; +Cc: linux-crypto
Hello George Cherian,
This is a semi-automatic email about new static checker warnings.
The patch c694b233295b: "crypto: cavium - Add the Virtual Function
driver for CPT" from Feb 7, 2017, leads to the following Smatch
complaint:
drivers/crypto/cavium/cpt/cptvf_main.c:899 cptvf_remove()
error: we previously assumed 'cptvf' could be null (see line 895)
drivers/crypto/cavium/cpt/cptvf_main.c
894
895 if (!cptvf)
^^^^^
Check for NULL.
896 dev_err(&pdev->dev, "Invalid CPT-VF device\n");
897
898 /* Convey DOWN to PF */
899 if (cptvf_send_vf_down(cptvf)) {
^^^^^
Oops inside function.
900 dev_err(&pdev->dev, "PF not responding to DOWN msg");
901 } else {
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-16 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-16 20:18 [bug report] crypto: cavium - Add the Virtual Function driver for CPT Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2017-02-15 8:39 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).