From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver Date: Fri, 24 Mar 2017 20:01:48 +0300 Message-ID: <20170324170148.ew7ozpt5jfwdx5yn@kozik-lap> References: <20170324142446.31129-1-krzk@kernel.org> <9265537.P6AeF50kg8@amdc3058> <20170324161934.kc6g36nazr3y32kp@kozik-lap> <87677624.EBdhaJY1KM@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-samsung-soc@vger.kernel.org, Herbert Xu , Arnd Bergmann , linux-kernel@vger.kernel.org, Javier Martinez Canillas , Kukjin Kim , linux-crypto@vger.kernel.org, Matt Mackall , Olof Johansson , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Marek Szyprowski To: Bartlomiej Zolnierkiewicz Return-path: Content-Disposition: inline In-Reply-To: <87677624.EBdhaJY1KM@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org On Fri, Mar 24, 2017 at 05:45:41PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > And I think the probe might be called twice, for example in case of > > > > mistake in DTB. > > > > > > Even if this is possible resource allocation code in the driver will > > > take take care of handling it just fine, > > > > Indeed, the devm_ioremap_resource() solves the case. I can drop the > > check then. > > Looking on this a bit more it seems that devm_ioremap_resource() will > not cover all mistakes (using compatible by mistake in some other DTB > node). > > Leave the check, I take my objection back. Great! Thanks for feedback. Best regards, Krzysztof