From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Stephan Müller" <smueller@chronox.de>
Cc: linux-samsung-soc@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-crypto@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Olof Johansson <olof@lixom.net>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver
Date: Sun, 26 Mar 2017 21:09:59 +0300 [thread overview]
Message-ID: <20170326180959.rmps6pj5376l45fz@kozik-lap> (raw)
In-Reply-To: <1535446.zHpTqe8jba@positron.chronox.de>
On Sun, Mar 26, 2017 at 07:05:48PM +0200, Stephan Müller wrote:
> Am Sonntag, 26. März 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan:
>
> Hi Krzysztof,
>
> > >> > + if (slen < EXYNOS_RNG_SEED_SIZE) {
> > >> > + dev_warn(rng->dev, "Seed too short (only %u bytes)\n",
> > >> > slen); + return -EINVAL;
> > >> > + }
> > >>
> > >> Will it be helpful to print the required seed size?
> > >
> > > It is in /proc/crypto... It is not a problem to print it but isn't that
> > > redundant?
> >
> > Not necessary if it is already available.
>
> Maybe the dev_warn should be removed. Note, unprivileged user space can
> trigger this warning by simply invoking the seeding operation over and over
> again with an insufficient seed size. This would clutter the log.
Makes sense. The generic dev_dbg() before would bring enough
information.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-03-26 18:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 16:26 [PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski
2017-03-25 16:26 ` [PATCH v3 1/3] " Krzysztof Kozlowski
2017-03-26 15:20 ` PrasannaKumar Muralidharan
2017-03-26 16:01 ` Krzysztof Kozlowski
2017-03-26 16:05 ` Stephan Müller
2017-03-26 16:46 ` PrasannaKumar Muralidharan
2017-03-26 17:05 ` Stephan Müller
2017-03-26 18:09 ` Krzysztof Kozlowski [this message]
2017-03-26 17:11 ` Stephan Müller
2017-03-26 18:00 ` Krzysztof Kozlowski
2017-03-26 21:25 ` Stephan Müller
2017-03-27 4:23 ` PrasannaKumar Muralidharan
2017-03-27 13:53 ` Stephan Müller
2017-03-28 16:48 ` Krzysztof Kozlowski
2017-03-28 17:41 ` Stephan Müller
2017-03-28 17:43 ` Krzysztof Kozlowski
2017-03-25 16:26 ` [PATCH v3 2/3] ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API Krzysztof Kozlowski
2017-03-25 16:26 ` [PATCH v3 3/3] ARM: multi_v7_defconfig: " Krzysztof Kozlowski
2017-03-25 16:32 ` [PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326180959.rmps6pj5376l45fz@kozik-lap \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=olof@lixom.net \
--cc=prasannatsmkumar@gmail.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox