From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
jason@lakedaemon.net, andrew@lunn.ch,
gregory.clement@free-electrons.com,
sebastian.hesselbarth@gmail.com,
thomas.petazzoni@free-electrons.com,
boris.brezillon@free-electrons.com, igall@marvell.com,
nadavh@marvell.com, linux-crypto@vger.kernel.org,
robin.murphy@arm.com, oferh@marvell.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver
Date: Fri, 21 Apr 2017 14:05:52 +0200 [thread overview]
Message-ID: <20170421120552.phujnp4csesm6p3h@kwain> (raw)
In-Reply-To: <20170421113645.GA18422@Red>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Fri, Apr 21, 2017 at 01:36:45PM +0200, Corentin Labbe wrote:
> > > > + memset(ipad + keylen, 0, blocksize - keylen);
> > > > + memcpy(opad, ipad, blocksize);
> > > > +
> > > > + for (i = 0; i < blocksize; i++) {
> > > > + ipad[i] ^= 0x36;
> > > > + opad[i] ^= 0x5c;
> > >
> > > What are these constant ?
> >
> > They are defined in the HMAC RFC, as ipad and opad values. See
> > https://www.ietf.org/rfc/rfc2104.txt.
> >
>
> Since many driver use them, I think defining them in include/ should be done (HMAC_IPAD/HMAC_OPAD)
> I will send a patch for it.
OK, I'll send a following up patch on this driver when your series is
merged.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-04-21 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 7:14 [PATCH v2 0/3] arm64: marvell: add cryptographic engine support for 7k/8k Antoine Tenart
2017-04-19 7:14 ` [PATCH v2 1/3] Documentation/bindings: Document the SafeXel cryptographic engine driver Antoine Tenart
2017-04-19 7:14 ` [PATCH v2 2/3] crypto: inside-secure: add SafeXcel EIP197 crypto " Antoine Tenart
2017-04-21 7:30 ` Corentin Labbe
2017-04-21 9:29 ` Antoine Tenart
2017-04-21 11:36 ` Corentin Labbe
2017-04-21 12:05 ` Antoine Tenart [this message]
2017-04-19 7:14 ` [PATCH v2 3/3] MAINTAINERS: add a maintainer for the Inside Secure crypto driver Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421120552.phujnp4csesm6p3h@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=boris.brezillon@free-electrons.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=igall@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=nadavh@marvell.com \
--cc=oferh@marvell.com \
--cc=robin.murphy@arm.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox