From: Eric Biggers <ebiggers3@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register
Date: Thu, 18 May 2017 19:50:17 -0700 [thread overview]
Message-ID: <20170519025017.GA14204@zzz> (raw)
In-Reply-To: <20170519015632.byuezk5ky22rqnkt@treble>
On Thu, May 18, 2017 at 08:56:32PM -0500, Josh Poimboeuf wrote:
> >
> > Hmm, it looks like a number of other algorithms in arch/x86/crypto/ use %rbp (or
> > %ebp), e.g. blowfish, camellia, cast5, and aes-i586. Presumably they have the
> > same problem. I'm a little confused: do these all need to be fixed, and
> > when/why did this start being considered broken?
>
> This warning was only recently added, with the goal of flushing out
> these types of issues with hand-coded asm to make frame pointer based
> stack traces more reliable. I can take a look at fixing the rest of
> them if you want.
>
Okay. I'm worried you might run into one that is difficult to fix due to lack
of spare registers. But if you're interested in looking into it, please go
ahead. Thanks!
Eric
next prev parent reply other threads:[~2017-05-19 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 4:03 [PATCH] crypto: x86/aes - Don't use %rbp as temporary register Eric Biggers
2017-05-17 20:44 ` Josh Poimboeuf
2017-05-17 22:21 ` Eric Biggers
2017-05-19 1:56 ` Josh Poimboeuf
2017-05-19 2:50 ` Eric Biggers [this message]
2017-05-23 5:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519025017.GA14204@zzz \
--to=ebiggers3@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=jpoimboe@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).