From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request
Date: Mon, 19 Jun 2017 09:55:24 +0200 [thread overview]
Message-ID: <20170619075524.GA27419@Red> (raw)
In-Reply-To: <20170619052707.GA13180@gondor.apana.org.au>
On Mon, Jun 19, 2017 at 01:27:08PM +0800, Herbert Xu wrote:
> On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote:
> > The crypto engine could actually only enqueue hash and ablkcipher request.
> > This patch permit it to enqueue skcipher requets by adding all necessary
> > functions.
> > The only problem is that ablkcipher and skcipher id are the same, so
> > only one cipher type is usable on the same crypto engine.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> I think this should be done as part of the skcipher conversion rather
> than as a standalone patch.
>
Since there are two different user of "crypto engine + ablkcipher", it will be not easy to convert them in one serie. (I could do it, but I simply could not test it for OMAP (lack of hw))
And any new user which want to use crypto engine+skcipher (like me with the sun8i-ce driver) are simply stuck.
Regards
next prev parent reply other threads:[~2017-06-19 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 13:44 [PATCH v2 0/2] crypto: engine - Permit to enqueue skcipher request Corentin Labbe
2017-06-06 13:44 ` [PATCH v2 1/2] crypto: engine - replace pr_xxx by dev_xxx Corentin Labbe
2017-06-19 6:46 ` Herbert Xu
2017-06-06 13:44 ` [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request Corentin Labbe
2017-06-06 14:07 ` Stephan Müller
2017-06-06 14:24 ` Corentin Labbe
2017-06-19 5:27 ` Herbert Xu
2017-06-19 7:55 ` Corentin Labbe [this message]
2017-06-23 6:48 ` Herbert Xu
2017-07-14 11:15 ` Corentin Labbe
2017-07-28 13:52 ` Herbert Xu
2017-07-28 15:01 ` Corentin Labbe
2017-08-09 9:40 ` Corentin Labbe
2017-08-21 15:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619075524.GA27419@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).