From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jhih-Ming Huang <fbihjmeric@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 05/11] Fix ERROR: space prohibited after that open parenthesis '('
Date: Tue, 20 Jun 2017 11:27:39 +0300 [thread overview]
Message-ID: <20170620082739.d647q2tlruk6vnbi@mwanda> (raw)
In-Reply-To: <1497936106-4673-1-git-send-email-fbihjmeric@gmail.com>
On Tue, Jun 20, 2017 at 01:21:46PM +0800, Jhih-Ming Huang wrote:
> From: Jhih-Ming Hunag <fbihjmeric@gmail.com>
>
> Fixed "ERROR: space prohibited after that open parenthesis '('".
>
> Signed-off-by: Jhih-Ming Hunag <fbihjmeric@gmail.com>
> ---
> drivers/staging/ccree/ssi_aead.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
> index 6bcab5a..5166874 100644
> --- a/drivers/staging/ccree/ssi_aead.c
> +++ b/drivers/staging/ccree/ssi_aead.c
> @@ -1375,10 +1375,10 @@ static int validate_data_size(struct ssi_aead_ctx *ctx,
> static unsigned int format_ccm_a0(u8 *pA0Buff, u32 headerSize)
> {
> unsigned int len = 0;
> - if ( headerSize == 0 ) {
> + if (headerSize == 0 ) {
Remove the other space as well. I looked ahead in the series so I see
that you do it later, but it should be done here.
regards,
dan carpenter
next prev parent reply other threads:[~2017-06-20 8:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 5:19 [PATCH 01/11] Fix coding style of driver/staging/ccree/ssi_aead.c ERROR: space required after that Jhih-Ming Huang
2017-06-20 5:20 ` [PATCH 02/11] Fix ERROR: spaces required around that Jhih-Ming Huang
2017-06-20 8:24 ` Dan Carpenter
2017-06-20 5:21 ` [PATCH 03/11] Fix ERROR: space required before the open brace Jhih-Ming Huang
2017-06-20 5:21 ` [PATCH 04/11] Fix ERROR: that open brace { should be on the previous line Jhih-Ming Huang
2017-06-20 5:21 ` [PATCH 05/11] Fix ERROR: space prohibited after that open parenthesis '(' Jhih-Ming Huang
2017-06-20 8:27 ` Dan Carpenter [this message]
2017-06-20 5:21 ` [PATCH 06/11] Fix ERROR: space prohibited before that close parenthesis ')' Jhih-Ming Huang
2017-06-20 5:22 ` [PATCH 07/11] Fix ERROR: open brace '{' following function declarations go on the next line Jhih-Ming Huang
2017-06-20 5:22 ` [PATCH 08/11] Fix ERROR: space prohibited before open square bracket '[' Jhih-Ming Huang
2017-06-20 5:22 ` [PATCH 09/11] Fix ERROR: space prohibited before that ',' Jhih-Ming Huang
2017-06-20 5:22 ` [PATCH 10/11] Fix ERROR: else should follow close brace '}' Jhih-Ming Huang
2017-06-20 5:23 ` [PATCH 11/11] Fix ERROR: "foo* bar" should be "foo *bar" Jhih-Ming Huang
2017-06-20 8:20 ` [PATCH 01/11] Fix coding style of driver/staging/ccree/ssi_aead.c ERROR: space required after that Dan Carpenter
2017-06-20 12:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620082739.d647q2tlruk6vnbi@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=fbihjmeric@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox