From: Brijesh Singh <brijesh.singh@amd.com>
To: linux-crypto@vger.kernel.org, thomas.lendacky@amd.com
Cc: gary.hook@amd.com, herbert@gondor.apana.org.au,
davem@davemloft.net, Brijesh Singh <brijesh.singh@amd.com>
Subject: [PATCH v3 RESEND 5/5] crypto: ccp - remove ccp_present() check from device initialize
Date: Thu, 29 Jun 2017 11:54:06 -0500 [thread overview]
Message-ID: <20170629165406.13463-6-brijesh.singh@amd.com> (raw)
In-Reply-To: <20170629165406.13463-1-brijesh.singh@amd.com>
Since SP device driver supports multiples devices (e.g CCP, PSP), we
should not fail the driver init just because CCP device is not found.
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
---
drivers/crypto/ccp/sp-dev.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c
index edbf1bd9..a017233 100644
--- a/drivers/crypto/ccp/sp-dev.c
+++ b/drivers/crypto/ccp/sp-dev.c
@@ -244,12 +244,6 @@ static int __init sp_mod_init(void)
if (ret)
return ret;
- /* Don't leave the driver loaded if init failed */
- if (ccp_present() != 0) {
- sp_pci_exit();
- return -ENODEV;
- }
-
return 0;
#endif
@@ -260,12 +254,6 @@ static int __init sp_mod_init(void)
if (ret)
return ret;
- /* Don't leave the driver loaded if init failed */
- if (ccp_present() != 0) {
- sp_platform_exit();
- return -ENODEV;
- }
-
return 0;
#endif
--
2.9.4
next prev parent reply other threads:[~2017-06-29 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 16:54 [PATCH v3 RESEND 0/5] Introduce AMD Secure Processor device Brijesh Singh
2017-06-29 16:54 ` [PATCH v3 RESEND 1/5] crypto: ccp - Use devres interface to allocate PCI/iomap and cleanup Brijesh Singh
2017-07-03 15:50 ` Gary R Hook
2017-06-29 16:54 ` [PATCH v3 RESEND 2/5] crypto: ccp - Introduce the AMD Secure Processor device Brijesh Singh
2017-07-03 15:50 ` Gary R Hook
2017-06-29 16:54 ` [PATCH v3 RESEND 3/5] crypto: cpp - Abstract interrupt registeration Brijesh Singh
2017-07-03 15:50 ` Gary R Hook
2017-06-29 16:54 ` [PATCH v3 RESEND 4/5] crypto: ccp - rename ccp driver initialize files as sp device Brijesh Singh
2017-07-03 15:51 ` Gary R Hook
2017-06-29 16:54 ` Brijesh Singh [this message]
2017-07-03 15:51 ` [PATCH v3 RESEND 5/5] crypto: ccp - remove ccp_present() check from device initialize Gary R Hook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629165406.13463-6-brijesh.singh@amd.com \
--to=brijesh.singh@amd.com \
--cc=davem@davemloft.net \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).