From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 7/8] staging: ccree: replace noop macro with inline
Date: Sat, 9 Sep 2017 12:11:57 +0300 [thread overview]
Message-ID: <20170909091157.wsotu253vngrz5rt@mwanda> (raw)
In-Reply-To: <1504429011-25514-8-git-send-email-gilad@benyossef.com>
On Sun, Sep 03, 2017 at 11:56:49AM +0300, Gilad Ben-Yossef wrote:
> Replace noop macro with a noop inline function
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> ---
> drivers/staging/ccree/ssi_driver.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h
> index 06a3c48..81ba827 100644
> --- a/drivers/staging/ccree/ssi_driver.h
> +++ b/drivers/staging/ccree/ssi_driver.h
> @@ -187,8 +187,8 @@ struct async_gen_req_ctx {
> #ifdef DX_DUMP_BYTES
> void dump_byte_array(const char *name, const u8 *the_array, unsigned long size);
> #else
> -#define dump_byte_array(name, array, size) do { \
> -} while (0);
> +static inline void dump_byte_array(const char *name, const u8 *the_array,
> + unsigned long size) {};
Could you put the {} on the next line? Also there is no need for the
semi-colon after the end of a function.
This is a style thing, so if you want to do it in a follow on patch
that's fine
regards,
dan carpenter
next prev parent reply other threads:[~2017-09-09 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 8:56 [PATCH 0/8] staging: ccree: more cleanup work for 4.14 Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 1/8] staging: ccree: Replace kzalloc with devm_kzalloc Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 2/8] staging: ccree: Convert to devm_ioremap_resource for map, unmap Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 3/8] staging: ccree: Use platform_get_irq and devm_request_irq Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 4/8] staging: ccree: simplify resource release on error Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 5/8] staging: ccree: remove unused completion Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 6/8] staging: ccree: move over to BIT macro for bit defines Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 7/8] staging: ccree: replace noop macro with inline Gilad Ben-Yossef
2017-09-09 9:11 ` Dan Carpenter [this message]
2017-09-03 8:56 ` [PATCH 8/8] staging: ccree: remove BUG macro usage Gilad Ben-Yossef
2017-09-06 19:28 ` Dan Carpenter
2017-09-07 9:00 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170909091157.wsotu253vngrz5rt@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox