From: David Sterba <dsterba@suse.cz>
To: Allen Pais <allen.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
target-devel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure.
Date: Wed, 13 Sep 2017 17:13:08 +0200 [thread overview]
Message-ID: <20170913151308.GL29043@twin.jikos.cz> (raw)
In-Reply-To: <1505287939-14106-10-git-send-email-allen.lkml@gmail.com>
On Wed, Sep 13, 2017 at 01:02:19PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> fs/btrfs/check-integrity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
> index 7d5a9b5..efa4c23 100644
> --- a/fs/btrfs/check-integrity.c
> +++ b/fs/btrfs/check-integrity.c
> @@ -2913,7 +2913,7 @@ int btrfsic_mount(struct btrfs_fs_info *fs_info,
> state = kvzalloc(sizeof(*state), GFP_KERNEL);
> if (!state) {
> pr_info("btrfs check-integrity: allocation failed!\n");
> - return -1;
> + return -ENOMEM;
Makes sense, also please fix the -1 a few lines below that also result
from failed memory allocation, indirectly from btrfsic_dev_state_alloc().
> }
>
> if (!btrfsic_is_initialized) {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-13 15:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 7:32 [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Allen Pais
2017-09-13 7:32 ` [PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure Allen Pais
2017-10-07 4:21 ` Herbert Xu
2017-09-13 7:32 ` [PATCH 03/10] driver:gpu: " Allen Pais
2017-10-12 17:55 ` [Nouveau] " Daniel Vetter
2017-09-13 7:32 ` [PATCH 04/10] drivers:mpt: " Allen Pais
2017-09-13 7:32 ` [PATCH 05/10] drivers:net: " Allen Pais
2017-09-13 12:09 ` Andrew Lunn
2017-09-13 13:05 ` Allen
2017-09-13 7:32 ` [PATCH 06/10] drivers:ethernet: " Allen Pais
2017-09-13 12:16 ` Andrew Lunn
2017-09-13 13:04 ` Allen
2017-09-13 16:20 ` David Miller
2017-09-13 7:32 ` [PATCH 07/10] driver:megaraid: " Allen Pais
2017-09-13 7:32 ` [PATCH 08/10] driver:cxgbit: return -NOMEM " Allen Pais
2017-09-13 7:32 ` [PATCH 09/10] driver:video: return -ENOMEM " Allen Pais
2017-09-13 7:32 ` [PATCH 10/10] fs:btrfs: " Allen Pais
2017-09-13 15:13 ` David Sterba [this message]
2017-09-13 14:53 ` [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Joe Perches
2017-09-14 4:43 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913151308.GL29043@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=allen.lkml@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox