From: "Tobin C. Harding" <me@tobin.cc>
To: Stephen Brennan <stephen@brennan.io>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: ccree: Fix lines longer than 80 characters
Date: Tue, 24 Oct 2017 14:02:45 +1100 [thread overview]
Message-ID: <20171024030245.GC1429@eros> (raw)
In-Reply-To: <20171023145318.8748-1-stephen@brennan.io>
On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote:
> Simply break down some long lines and tab-indent them.
Hi Stephen,
Welcome to the Linux kernel. Great that you have put in a patch, you are, however, unlikely to see
success fixing 'line over 80' warnings. There are a bunch of arguments for and against the line over
80 limit, a web search will surely show them to you. The TL;DR is that it these changes do not
_really_ improve the readability of the code, they are just changes to quiet the static analysis
tool.
There are a bunch of other white space fixes that are more beneficial, perhaps you could wet your
feet with these (incorrect placement of parenthesis for example).
Good luck,
Tobin.
next prev parent reply other threads:[~2017-10-24 3:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 14:53 [PATCH] staging: ccree: Fix lines longer than 80 characters Stephen Brennan
2017-10-24 3:02 ` Tobin C. Harding [this message]
2017-10-24 8:49 ` Gilad Ben-Yossef
-- strict thread matches above, loose matches on Subject: below --
2017-10-27 1:51 Stephen Brennan
2017-10-27 1:53 ` Stephen Brennan
2017-10-10 4:27 Stephen Brennan
2017-10-20 19:57 ` Stephen Brennan
2017-10-21 7:48 ` Gilad Ben-Yossef
2017-10-23 15:00 ` Stephen Brennan
2017-10-24 8:54 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024030245.GC1429@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=stephen@brennan.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).