Re: [PATCH] crypto: skcipher - Fix skcipher_walk_aead_common

[Herbert Xu <herbert@gondor.apana.org.au>]

On Fri, Nov 24, 2017 at 11:53:53AM +0100, Ondrej Mosnáček wrote:
> (I accidentally hit "reply" instead of "reply all", so resending)
> 
> 2017-11-24 6:07 GMT+01:00 Herbert Xu <herbert@gondor.apana.org.au>:
> > On Thu, Nov 23, 2017 at 01:49:06PM +0100, Ondrej Mosnacek wrote:
> >> diff --git a/crypto/skcipher.c b/crypto/skcipher.c
> >> index 4faa0fd53b0c..6c45ed536664 100644
> >> --- a/crypto/skcipher.c
> >> +++ b/crypto/skcipher.c
> >> @@ -517,6 +517,9 @@ static int skcipher_walk_aead_common(struct skcipher_walk *walk,
> >>       scatterwalk_copychunks(NULL, &walk->in, req->assoclen, 2);
> >>       scatterwalk_copychunks(NULL, &walk->out, req->assoclen, 2);
> >>
> >> +     scatterwalk_done(&walk->in, 0, walk->total);
> >> +     scatterwalk_done(&walk->out, 0, walk->total);
> >
> > That should be 1 instead of 0 for walk->out.
> >
> > Could you please fix and resubmit?
> 
> Since the associated data is not written, just skipped, I believe 0 is
> more appropriate. scatterwalk_copychunks(..., 2) also calls
> scatterwalk_pagedone() with out=0 internally.

Thanks for the explanation.

Patch applied.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt