From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 01/10] staging: ccree: remove inline qualifiers
Date: Mon, 4 Dec 2017 12:36:39 +0300 [thread overview]
Message-ID: <20171204093639.7ctulxb4v2htqbmj@mwanda> (raw)
In-Reply-To: <1512309503-29766-2-git-send-email-gilad@benyossef.com>
On Sun, Dec 03, 2017 at 01:58:12PM +0000, Gilad Ben-Yossef wrote:
> The ccree drivers was marking a lot of big functions in C file as
> static inline for no good reason. Remove the inline qualifier from
> any but the few truly single line functions.
>
The compiler is free to ignore inline hints... It probably would make
single line functions inline anyway.
regards,
dan carpenter
next prev parent reply other threads:[~2017-12-04 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 13:58 [PATCH 00/10] staging: ccree: cleanups & fixes Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 01/10] staging: ccree: remove inline qualifiers Gilad Ben-Yossef
2017-12-04 9:36 ` Dan Carpenter [this message]
2017-12-07 7:00 ` Gilad Ben-Yossef
2017-12-07 8:28 ` Dan Carpenter
2017-12-03 13:58 ` [PATCH 02/10] staging: ccree: remove unproven likely/unlikely Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 03/10] staging: ccree: remove more unnecessary parentheses Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 04/10] staging: ccree: fix indentation of var assignment Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 05/10] staging: ccree: remove braces for single statement blocks Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 06/10] staging: ccree: remove interim DT docs Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 07/10] staging: ccree: update TODO list Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 08/10] staging: ccree: NULLify backup_info when unused Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 09/10] staging: ccree: fix AEAD func naming convention Gilad Ben-Yossef
2017-12-03 13:58 ` [PATCH 10/10] staging: ccree: amend aead func def for readability Gilad Ben-Yossef
2017-12-04 9:42 ` [PATCH 00/10] staging: ccree: cleanups & fixes Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204093639.7ctulxb4v2htqbmj@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox