linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] checkpatch: add *_ON_STACK to declaration_macros
@ 2017-12-20  8:31 Gilad Ben-Yossef
  2017-12-20  9:33 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Gilad Ben-Yossef @ 2017-12-20  8:31 UTC (permalink / raw)
  To: Andy Whitcroft, Joe Perches
  Cc: Ofir Drang, linux-crypto, Greg Kroah-Hartman, linux-kernel

Add the crypto API *_ON_STACK to $declaration_macros.

Resolves the following false warning:

WARNING: Missing a blank line after declarations
+			int err;
+			SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
 scripts/checkpatch.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 168687a..e7fa1a2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -759,6 +759,7 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
 our $declaration_macros = qr{(?x:
 	(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
 	(?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|
+	(?:$Storage\s+)?[A-Z_]*_ON_STACK\(|
 	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
 )};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] checkpatch: add *_ON_STACK to declaration_macros
  2017-12-20  8:31 [PATCH RESEND] checkpatch: add *_ON_STACK to declaration_macros Gilad Ben-Yossef
@ 2017-12-20  9:33 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-12-20  9:33 UTC (permalink / raw)
  To: Gilad Ben-Yossef
  Cc: Andy Whitcroft, Joe Perches, Ofir Drang, linux-crypto,
	linux-kernel

On Wed, Dec 20, 2017 at 08:31:19AM +0000, Gilad Ben-Yossef wrote:
> Add the crypto API *_ON_STACK to $declaration_macros.
> 
> Resolves the following false warning:
> 
> WARNING: Missing a blank line after declarations
> +			int err;
> +			SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-20  9:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-20  8:31 [PATCH RESEND] checkpatch: add *_ON_STACK to declaration_macros Gilad Ben-Yossef
2017-12-20  9:33 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).