From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Colin King <colin.king@canonical.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
Date: Wed, 3 Jan 2018 09:38:11 +0100 [thread overview]
Message-ID: <20180103083811.GA21727@kwain> (raw)
In-Reply-To: <20180102143410.13261-1-colin.king@canonical.com>
Hi Colin,
On Tue, Jan 02, 2018 at 02:34:10PM +0000, Colin King wrote:
>
> /* Called with ring's lock taken */
> -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring,
> - int reqs)
> +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv,
> + int ring, int reqs)
Alignment should match open parenthesis, one space is missing. Otherwise,
looks good to me.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2018-01-03 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 14:34 [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static Colin King
2018-01-03 8:38 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103083811.GA21727@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).