From: Eric Biggers <ebiggers3@gmail.com>
To: linux-crypto@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@google.com>
Subject: [PATCH v2 0/3] crypto: salsa20 - cleanup and convert to skcipher API
Date: Fri, 5 Jan 2018 11:09:56 -0800 [thread overview]
Message-ID: <20180105190959.89682-1-ebiggers3@gmail.com> (raw)
From: Eric Biggers <ebiggers@google.com>
This series converts the Salsa20 implementations over to the skcipher
API, in the process fixing a couple bugs and making them be more similar
to the ChaCha20 implementations, rather than doing things slightly
differently for no good reason. (Note, however, that Salsa20 still
interprets the IV differently from ChaCha20; I didn't change that.)
I'm not sure who is actually using Salsa20 in the kernel, but either way
if we're going to have it at all we might as well keep it up to date.
The Salsa20 algorithms still pass the self-tests after these changes.
Changed since v1:
- Use '__le32' type for keystream, as suggested by Stephan.
Eric Biggers (3):
crypto: salsa20-generic - cleanup and convert to skcipher API
crypto: salsa20 - export generic helpers
crypto: x86/salsa20 - cleanup and convert to skcipher API
arch/x86/crypto/salsa20-i586-asm_32.S | 184 +-----------------------
arch/x86/crypto/salsa20-x86_64-asm_64.S | 114 ---------------
arch/x86/crypto/salsa20_glue.c | 105 ++++++--------
crypto/Kconfig | 2 +
crypto/salsa20_generic.c | 240 ++++++++++++++------------------
include/crypto/salsa20.h | 27 ++++
6 files changed, 174 insertions(+), 498 deletions(-)
create mode 100644 include/crypto/salsa20.h
--
2.16.0.rc0.223.g4a4ac83678-goog
next reply other threads:[~2018-01-05 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 19:09 Eric Biggers [this message]
2018-01-05 19:09 ` [PATCH v2 1/3] crypto: salsa20-generic - cleanup and convert to skcipher API Eric Biggers
2018-01-05 19:09 ` [PATCH v2 2/3] crypto: salsa20 - export generic helpers Eric Biggers
2018-01-05 19:09 ` [PATCH v2 3/3] crypto: x86/salsa20 - cleanup and convert to skcipher API Eric Biggers
2018-01-12 12:25 ` [PATCH v2 0/3] crypto: salsa20 " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105190959.89682-1-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).