linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-crypto@vger.kernel.org, devel@driverdev.osuosl.org,
	driverdev-devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org, Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH v3 24/27] staging: ccree: use a consistent file naming convention
Date: Mon, 8 Jan 2018 16:28:18 +0100	[thread overview]
Message-ID: <20180108152818.GA7701@kroah.com> (raw)
In-Reply-To: <1515327285-8948-25-git-send-email-gilad@benyossef.com>

On Sun, Jan 07, 2018 at 12:14:35PM +0000, Gilad Ben-Yossef wrote:
> The ccree driver source files were using an inconsistent
> naming convention stemming from what the company was called
> when they were added.
> 
> Move to a single consistent naming convention for better
> code readability.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> ---
>  drivers/staging/ccree/Makefile           |    6 +-
>  drivers/staging/ccree/cc_aead.c          | 2709 ++++++++++++++++++++++++++++++
>  drivers/staging/ccree/cc_aead.h          |  109 ++
>  drivers/staging/ccree/cc_buffer_mgr.c    | 1657 ++++++++++++++++++
>  drivers/staging/ccree/cc_buffer_mgr.h    |   74 +
>  drivers/staging/ccree/cc_cipher.c        | 1171 +++++++++++++
>  drivers/staging/ccree/cc_cipher.h        |   74 +
>  drivers/staging/ccree/cc_debugfs.c       |    2 +-
>  drivers/staging/ccree/cc_driver.c        |  508 ++++++
>  drivers/staging/ccree/cc_driver.h        |  194 +++
>  drivers/staging/ccree/cc_fips.c          |  112 ++
>  drivers/staging/ccree/cc_fips.h          |   37 +
>  drivers/staging/ccree/cc_hash.c          | 2299 +++++++++++++++++++++++++
>  drivers/staging/ccree/cc_hash.h          |  114 ++
>  drivers/staging/ccree/cc_host_regs.h     |  142 ++
>  drivers/staging/ccree/cc_hw_queue_defs.h |    2 +-
>  drivers/staging/ccree/cc_ivgen.c         |  281 ++++
>  drivers/staging/ccree/cc_ivgen.h         |   55 +
>  drivers/staging/ccree/cc_kernel_regs.h   |  167 ++
>  drivers/staging/ccree/cc_pm.c            |  125 ++
>  drivers/staging/ccree/cc_pm.h            |   57 +
>  drivers/staging/ccree/cc_request_mgr.c   |  719 ++++++++
>  drivers/staging/ccree/cc_request_mgr.h   |   51 +
>  drivers/staging/ccree/cc_sram_mgr.c      |  107 ++
>  drivers/staging/ccree/cc_sram_mgr.h      |   65 +
>  drivers/staging/ccree/dx_crys_kernel.h   |  167 --
>  drivers/staging/ccree/dx_host.h          |  142 --
>  drivers/staging/ccree/ssi_aead.c         | 2709 ------------------------------
>  drivers/staging/ccree/ssi_aead.h         |  109 --
>  drivers/staging/ccree/ssi_buffer_mgr.c   | 1657 ------------------
>  drivers/staging/ccree/ssi_buffer_mgr.h   |   74 -
>  drivers/staging/ccree/ssi_cipher.c       | 1171 -------------
>  drivers/staging/ccree/ssi_cipher.h       |   74 -
>  drivers/staging/ccree/ssi_driver.c       |  508 ------
>  drivers/staging/ccree/ssi_driver.h       |  194 ---
>  drivers/staging/ccree/ssi_fips.c         |  112 --
>  drivers/staging/ccree/ssi_fips.h         |   37 -
>  drivers/staging/ccree/ssi_hash.c         | 2299 -------------------------
>  drivers/staging/ccree/ssi_hash.h         |  114 --
>  drivers/staging/ccree/ssi_ivgen.c        |  281 ----
>  drivers/staging/ccree/ssi_ivgen.h        |   55 -
>  drivers/staging/ccree/ssi_pm.c           |  125 --
>  drivers/staging/ccree/ssi_pm.h           |   57 -
>  drivers/staging/ccree/ssi_request_mgr.c  |  719 --------
>  drivers/staging/ccree/ssi_request_mgr.h  |   51 -
>  drivers/staging/ccree/ssi_sram_mgr.c     |  107 --
>  drivers/staging/ccree/ssi_sram_mgr.h     |   65 -
>  47 files changed, 10832 insertions(+), 10832 deletions(-)
>  create mode 100644 drivers/staging/ccree/cc_aead.c
>  create mode 100644 drivers/staging/ccree/cc_aead.h
>  create mode 100644 drivers/staging/ccree/cc_buffer_mgr.c
>  create mode 100644 drivers/staging/ccree/cc_buffer_mgr.h
>  create mode 100644 drivers/staging/ccree/cc_cipher.c
>  create mode 100644 drivers/staging/ccree/cc_cipher.h
>  create mode 100644 drivers/staging/ccree/cc_driver.c
>  create mode 100644 drivers/staging/ccree/cc_driver.h
>  create mode 100644 drivers/staging/ccree/cc_fips.c
>  create mode 100644 drivers/staging/ccree/cc_fips.h
>  create mode 100644 drivers/staging/ccree/cc_hash.c
>  create mode 100644 drivers/staging/ccree/cc_hash.h
>  create mode 100644 drivers/staging/ccree/cc_host_regs.h
>  create mode 100644 drivers/staging/ccree/cc_ivgen.c
>  create mode 100644 drivers/staging/ccree/cc_ivgen.h
>  create mode 100644 drivers/staging/ccree/cc_kernel_regs.h
>  create mode 100644 drivers/staging/ccree/cc_pm.c
>  create mode 100644 drivers/staging/ccree/cc_pm.h
>  create mode 100644 drivers/staging/ccree/cc_request_mgr.c
>  create mode 100644 drivers/staging/ccree/cc_request_mgr.h
>  create mode 100644 drivers/staging/ccree/cc_sram_mgr.c
>  create mode 100644 drivers/staging/ccree/cc_sram_mgr.h
>  delete mode 100644 drivers/staging/ccree/dx_crys_kernel.h
>  delete mode 100644 drivers/staging/ccree/dx_host.h
>  delete mode 100644 drivers/staging/ccree/ssi_aead.c
>  delete mode 100644 drivers/staging/ccree/ssi_aead.h
>  delete mode 100644 drivers/staging/ccree/ssi_buffer_mgr.c
>  delete mode 100644 drivers/staging/ccree/ssi_buffer_mgr.h
>  delete mode 100644 drivers/staging/ccree/ssi_cipher.c
>  delete mode 100644 drivers/staging/ccree/ssi_cipher.h
>  delete mode 100644 drivers/staging/ccree/ssi_driver.c
>  delete mode 100644 drivers/staging/ccree/ssi_driver.h
>  delete mode 100644 drivers/staging/ccree/ssi_fips.c
>  delete mode 100644 drivers/staging/ccree/ssi_fips.h
>  delete mode 100644 drivers/staging/ccree/ssi_hash.c
>  delete mode 100644 drivers/staging/ccree/ssi_hash.h
>  delete mode 100644 drivers/staging/ccree/ssi_ivgen.c
>  delete mode 100644 drivers/staging/ccree/ssi_ivgen.h
>  delete mode 100644 drivers/staging/ccree/ssi_pm.c
>  delete mode 100644 drivers/staging/ccree/ssi_pm.h
>  delete mode 100644 drivers/staging/ccree/ssi_request_mgr.c
>  delete mode 100644 drivers/staging/ccree/ssi_request_mgr.h
>  delete mode 100644 drivers/staging/ccree/ssi_sram_mgr.c
>  delete mode 100644 drivers/staging/ccree/ssi_sram_mgr.h

Can you redo this with the -M option to git format-patch so we can see
the files move, and not be deleted and added again?

thanks,

greg k-h

  reply	other threads:[~2018-01-08 15:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07 12:14 [PATCH v3 00/27] staging: ccree: fixes and cleanups Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 01/27] staging: ccree: SPDXify driver Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 02/27] staging: ccree: fold hash defs into queue defs Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 03/27] staging: ccree: fold reg common defines into driver Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 04/27] staging: ccree: remove GFP_DMA flag from mem allocs Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 05/27] staging: ccree: pick alloc mem flags based on req flags Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 06/27] staging: ccree: copy larval digest from RAM Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 07/27] staging: ccree: tag debugfs init/exit func properly Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 08/27] staging: ccree: remove unused leftover field Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 09/27] staging: ccree: break send_request and fix ret val Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 10/27] staging: ccree: add backlog processing Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 11/27] stating: ccree: revert "staging: ccree: fix leak of import() after init()" Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 12/27] staging: ccree: failing the suspend is not an error Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 13/27] staging: ccree: check DMA pool buf !NULL before free Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 14/27] staging: ccree: handle end of sg list gracefully Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 15/27] staging: ccree: use Makefile to include PM code Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 16/27] staging: ccree: remove unused field Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 17/27] staging: ccree: use array for double buffer Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 18/27] staging: ccree: allocate hash bufs inside req ctx Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 19/27] staging: ccree: do not map bufs in ahash_init Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 20/27] staging: ccree: fix indentation of func params Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 21/27] staging: ccree: fold common code into service func Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 22/27] staging: ccree: put pointer next to var name Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 23/27] stating: ccree: fix allocation of void sized buf Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 24/27] staging: ccree: use a consistent file naming convention Gilad Ben-Yossef
2018-01-08 15:28   ` Greg Kroah-Hartman [this message]
2018-01-09  7:42     ` Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 25/27] staging: ccree: remove unneeded includes Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 26/27] staging: ccree: update TODO Gilad Ben-Yossef
2018-01-07 12:14 ` [PATCH v3 27/27] staging: ccree: add missing include Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108152818.GA7701@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gilad@benyossef.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ofir.drang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).