From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Gilad Ben-Yossef <gilad@benyossef.com>,
dm-devel@redhat.com,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: dm-integrity: don't store cipher request on the stack (was: [QUESTION] hash import and request initialization)
Date: Wed, 10 Jan 2018 10:13:53 -0500 [thread overview]
Message-ID: <20180110151353.GA23626@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1801100931240.7460@file01.intranet.prod.int.rdu2.redhat.com>
On Wed, Jan 10 2018 at 9:32am -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
> On Wed, 27 Dec 2017, Herbert Xu wrote:
>
> > On Tue, Dec 26, 2017 at 02:21:53PM +0200, Gilad Ben-Yossef wrote:
> > >
> > > See how SKCIPHER_REQUEST_ON_STACK is being used with an asymmetric skcipher
> > > in drivers/md/dm-integrity.c
> >
> > That's just broken. SKCIPHER_REQUEST_ON_STACK is only meant for
> > sync algorithms and this code needs to be changed to either do the
> > proper request allocation or switch over to allocating sync
> > algorithms.
> >
> > Cheers,
>
> Hi
>
> Here I send a patch that moves those allocations to the heap.
Thanks, I'll review and hope to stage for 4.16 today.
Mike
prev parent reply other threads:[~2018-01-10 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 8:07 [QUESTION] hash import and request initialization Gilad Ben-Yossef
2017-12-26 3:07 ` Herbert Xu
2017-12-26 9:06 ` Gilad Ben-Yossef
2017-12-26 10:40 ` Herbert Xu
2017-12-26 12:21 ` Gilad Ben-Yossef
2017-12-27 3:35 ` Herbert Xu
2017-12-27 6:27 ` Gilad Ben-Yossef
2018-01-10 14:32 ` [PATCH] dm-integrity: don't store cipher request on the stack (was: [QUESTION] hash import and request initialization) Mikulas Patocka
2018-01-10 15:13 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110151353.GA23626@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).