From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Ofir Drang <Ofir.Drang@arm.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: Getting the ccree driver out of staging
Date: Wed, 10 Jan 2018 17:39:26 +0100 [thread overview]
Message-ID: <20180110163926.GA25674@kroah.com> (raw)
In-Reply-To: <CAOtvUMdo_ZJ-M-=apA1a=70KyVBX2J0pEVc+Uc9i=rYWCie6Hw@mail.gmail.com>
On Wed, Jan 10, 2018 at 08:54:55AM +0200, Gilad Ben-Yossef wrote:
> Hi folks,
>
> With the enormous help of people in the to and CCed lists I've gotten
> the ccree driver to a point I believe it is ready to graduate out of
> the staging tree:
>
> - The code base has been reduced by something by 30% and is *much*
> more readable and manageable.
> - The very few checkpatch warnings are all false positives (one due to
> dt bindings going through the crypto tree, the others due to harmless
> macro argument reuse)
> and the few sparse output are equally benign.
> - The driver follows the crypto API expected behavior as much as I can tell.
> - Fixed all the bugs I could fine as a result of tcrypt tests.
> - It works :-)
>
> There are obviously more things todo, but I believe they are out of
> scope for staging.
>
> So, if you see something that still needs work, kindly let me know.
> Alternatively, will you accept a patch moving it to drivers/crypto/?
It might make more sense to just send a "new" patch adding the driver to
drivers/crypto/ and if that is accepted, we can drop it from staging.
That way it's easier for the crypto developers to review it.
But it's up to them, whatever they want is fine with me.
thanks,
greg k-h
next prev parent reply other threads:[~2018-01-10 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 6:54 Getting the ccree driver out of staging Gilad Ben-Yossef
2018-01-10 16:39 ` Greg Kroah-Hartman [this message]
2018-01-11 6:33 ` Gilad Ben-Yossef
2018-01-11 6:34 ` Herbert Xu
2018-01-11 8:42 ` Dan Carpenter
2018-01-21 15:15 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110163926.GA25674@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Ofir.Drang@arm.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox