public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: devel@driverdev.osuosl.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Ofir Drang <Ofir.Drang@arm.com>
Subject: Re: Getting the ccree driver out of staging
Date: Thu, 11 Jan 2018 11:42:16 +0300	[thread overview]
Message-ID: <20180111084216.oq7pnj6iwgatdld2@mwanda> (raw)
In-Reply-To: <CAOtvUMdo_ZJ-M-=apA1a=70KyVBX2J0pEVc+Uc9i=rYWCie6Hw@mail.gmail.com>

Here are my remaining Smatch warnings:

    drivers/staging/ccree/cc_driver.c:219 init_cc_resources()
    error: '%pa' can only be followed by one of [dp]

drivers/staging/ccree/cc_driver.c
   217  
   218          if (rc) {
   219                  dev_err(dev, "Failed in dma_set_mask, mask=%par\n",
                                                                      ^
This 'r' is is treated as a 'p'.  Not sure what was intended.

   220                          &dma_mask);
   221                  return rc;
   222          }
   223  


    drivers/staging/ccree/cc_buffer_mgr.c:1067 cc_aead_chain_data()
    warn: inconsistent indenting

drivers/staging/ccree/cc_buffer_mgr.c
  1064          if (src_mapped_nents > LLI_MAX_NUM_OF_DATA_ENTRIES) {
  1065                  dev_err(dev, "Too many fragments. current %d max %d\n",
  1066                          src_mapped_nents, LLI_MAX_NUM_OF_DATA_ENTRIES);
  1067                          return -ENOMEM;
                                ^^^^^^^^^^^^^^
  1068          }

    drivers/staging/ccree/cc_cipher.c:373 cc_cipher_setkey()
    warn: inconsistent indenting

drivers/staging/ccree/cc_cipher.c
   369          dma_sync_single_for_device(dev, ctx_p->user.key_dma_addr,
   370                                     max_key_buf_size, DMA_TO_DEVICE);
   371          ctx_p->keylen = keylen;
   372  
   373           dev_dbg(dev, "return safely");
                ^
One extra space.

   374          return 0;
   375  }

regards,
dan carpenter

  parent reply	other threads:[~2018-01-11  8:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10  6:54 Getting the ccree driver out of staging Gilad Ben-Yossef
2018-01-10 16:39 ` Greg Kroah-Hartman
2018-01-11  6:33   ` Gilad Ben-Yossef
2018-01-11  6:34     ` Herbert Xu
2018-01-11  8:42 ` Dan Carpenter [this message]
2018-01-21 15:15   ` Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111084216.oq7pnj6iwgatdld2@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Ofir.Drang@arm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gilad@benyossef.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox