From: Dan Carpenter <dan.carpenter@oracle.com>
To: brijesh.singh@amd.com
Cc: linux-crypto@vger.kernel.org
Subject: [bug report] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support
Date: Tue, 16 Jan 2018 13:57:23 +0300 [thread overview]
Message-ID: <20180116105723.GA4755@mwanda> (raw)
Hello Brijesh Singh,
The patch 200664d5237f: "crypto: ccp: Add Secure Encrypted
Virtualization (SEV) command support" from Dec 4, 2017, leads to the
following static checker warning:
drivers/crypto/ccp/psp-dev.c:779 psp_pci_init()
error: uninitialized symbol 'error'.
drivers/crypto/ccp/psp-dev.c
764 void psp_pci_init(void)
765 {
766 struct sev_user_data_status *status;
767 struct sp_device *sp;
768 int error, rc;
769
770 sp = sp_get_psp_master_device();
771 if (!sp)
772 return;
773
774 psp_master = sp->psp_data;
775
776 /* Initialize the platform */
777 rc = sev_platform_init(&error);
778 if (rc) {
779 dev_err(sp->dev, "SEV: failed to INIT error %#x\n", error);
^^^^^
Generally not set on the error paths.
780 goto err;
781 }
782
783 /* Display SEV firmware version */
regards,
dan carpenter
reply other threads:[~2018-01-16 10:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116105723.GA4755@mwanda \
--to=dan.carpenter@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox