linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support
@ 2018-01-16 10:57 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-01-16 10:57 UTC (permalink / raw)
  To: brijesh.singh; +Cc: linux-crypto

Hello Brijesh Singh,

The patch 200664d5237f: "crypto: ccp: Add Secure Encrypted
Virtualization (SEV) command support" from Dec 4, 2017, leads to the
following static checker warning:

	drivers/crypto/ccp/psp-dev.c:779 psp_pci_init()
	error: uninitialized symbol 'error'.

drivers/crypto/ccp/psp-dev.c
   764  void psp_pci_init(void)
   765  {
   766          struct sev_user_data_status *status;
   767          struct sp_device *sp;
   768          int error, rc;
   769  
   770          sp = sp_get_psp_master_device();
   771          if (!sp)
   772                  return;
   773  
   774          psp_master = sp->psp_data;
   775  
   776          /* Initialize the platform */
   777          rc = sev_platform_init(&error);
   778          if (rc) {
   779                  dev_err(sp->dev, "SEV: failed to INIT error %#x\n", error);
                                                                            ^^^^^
Generally not set on the error paths.

   780                  goto err;
   781          }
   782  
   783          /* Display SEV firmware version */

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-16 10:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 10:57 [bug report] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).