public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Watson <davejwatson@fb.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: "sd@queasysnail.net" <sd@queasysnail.net>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"ganeshgr@chelsio.co" <ganeshgr@chelsio.co>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Boris Pismenny <borisp@mellanox.com>,
	Ilya Lesokhin <ilyal@mellanox.com>
Subject: Re: [RFC crypto v3 8/9] chtls: Register the ULP
Date: Tue, 30 Jan 2018 09:11:44 -0800	[thread overview]
Message-ID: <20180130171144.GA42146@davejwatson-mba> (raw)
In-Reply-To: <CY4PR1201MB0230042A4D0EA83DC8F1BE7397E40@CY4PR1201MB0230.namprd12.prod.outlook.com>

On 01/30/18 06:51 AM, Atul Gupta wrote:

> What I was referring is that passing "tls" ulp type in setsockopt
> may be insufficient to make the decision when multi HW assist Inline
> TLS solution exists.

Setting the ULP doesn't choose HW or SW implementation, I think that
should be done later when setting up crypto with 

setsockopt(SOL_TLS, TLS_TX, struct crypto_info).

Any reason we can't use ethtool to choose HW vs SW implementation, if
available on the device?

> Some HW may go beyond defining sendmsg/sendpage of the prot and
> require additional info to setup the env? Also, we need to keep
> vendor specific code out of tls_main.c i.e anything other than
> base/sw_tx prot perhaps go to hw driver.

Sure, but I think we can add hooks to tls_main to do this without a
new ULP.

  reply	other threads:[~2018-01-30 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 21:08 [RFC crypto v3 8/9] chtls: Register the ULP Dave Watson
2018-01-28  5:55 ` Atul Gupta
2018-01-30  6:51   ` Atul Gupta
2018-01-30 17:11     ` Dave Watson [this message]
2018-01-31 10:44       ` Atul Gupta
2018-01-31 16:43         ` Dave Watson
2018-01-31 18:28           ` Atul Gupta
2018-02-08 10:26             ` Atul Gupta
2018-02-08 10:34               ` Vakul Garg
  -- strict thread matches above, loose matches on Subject: below --
2017-12-20 11:38 Atul Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130171144.GA42146@davejwatson-mba \
    --to=davejwatson@fb.com \
    --cc=atul.gupta@chelsio.com \
    --cc=borisp@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=ganeshgr@chelsio.co \
    --cc=herbert@gondor.apana.org.au \
    --cc=ilyal@mellanox.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox