From: Artem Savkov <artem.savkov@gmail.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Artem Savkov <artem.savkov@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org
Subject: [PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate
Date: Tue, 6 Feb 2018 22:20:21 +0100 [thread overview]
Message-ID: <20180206212022.1309-2-artem.savkov@gmail.com> (raw)
In-Reply-To: <20180206212022.1309-1-artem.savkov@gmail.com>
According to crypto/rng.h generate function should return 0 on success
and < 0 on error.
Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG")
Signed-off-by: Artem Savkov <artem.savkov@gmail.com>
---
drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-prng.c b/drivers/crypto/sunxi-ss/sun4i-ss-prng.c
index 0d01d1624252..5754e0b92fb0 100644
--- a/drivers/crypto/sunxi-ss/sun4i-ss-prng.c
+++ b/drivers/crypto/sunxi-ss/sun4i-ss-prng.c
@@ -52,5 +52,5 @@ int sun4i_ss_prng_generate(struct crypto_rng *tfm, const u8 *src,
writel(0, ss->base + SS_CTL);
spin_unlock(&ss->slock);
- return dlen;
+ return 0;
}
--
2.15.1
next prev parent reply other threads:[~2018-02-06 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:20 [PATCH 0/2] sun4i_ss_prng fixes Artem Savkov
2018-02-06 21:20 ` Artem Savkov [this message]
2018-02-07 9:56 ` [PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate Corentin Labbe
2018-02-07 10:52 ` Artem Savkov
2018-02-07 13:12 ` Corentin Labbe
2018-02-06 21:20 ` [PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate Artem Savkov
2018-02-09 15:51 ` [PATCH 0/2] sun4i_ss_prng fixes Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206212022.1309-2-artem.savkov@gmail.com \
--to=artem.savkov@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).