* [PATCH] crypto: ccp - Make function ccp_get_dma_chan_attr static
@ 2018-02-06 23:20 Colin King
2018-02-15 15:52 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-02-06 23:20 UTC (permalink / raw)
To: Tom Lendacky, Gary Hook, Herbert Xu, David S . Miller,
linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Function ccp_get_dma_chan_attr is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/crypto/ccp/ccp-dmaengine.c:41:14: warning: symbol
'ccp_get_dma_chan_attr' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
index 8b9da58459df..67155cb21636 100644
--- a/drivers/crypto/ccp/ccp-dmaengine.c
+++ b/drivers/crypto/ccp/ccp-dmaengine.c
@@ -38,7 +38,7 @@ static unsigned int dma_chan_attr = CCP_DMA_DFLT;
module_param(dma_chan_attr, uint, 0444);
MODULE_PARM_DESC(dma_chan_attr, "Set DMA channel visibility: 0 (default) = device defaults, 1 = make private, 2 = make public");
-unsigned int ccp_get_dma_chan_attr(struct ccp_device *ccp)
+static unsigned int ccp_get_dma_chan_attr(struct ccp_device *ccp)
{
switch (dma_chan_attr) {
case CCP_DMA_DFLT:
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] crypto: ccp - Make function ccp_get_dma_chan_attr static
2018-02-06 23:20 [PATCH] crypto: ccp - Make function ccp_get_dma_chan_attr static Colin King
@ 2018-02-15 15:52 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2018-02-15 15:52 UTC (permalink / raw)
To: Colin King
Cc: Tom Lendacky, Gary Hook, David S . Miller, linux-crypto,
kernel-janitors, linux-kernel
On Tue, Feb 06, 2018 at 11:20:01PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function ccp_get_dma_chan_attr is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/crypto/ccp/ccp-dmaengine.c:41:14: warning: symbol
> 'ccp_get_dma_chan_attr' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-15 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-06 23:20 [PATCH] crypto: ccp - Make function ccp_get_dma_chan_attr static Colin King
2018-02-15 15:52 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).