From: Eric Biggers <ebiggers3@gmail.com>
To: efremov@linux.com
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] crypto: skcipher: remove static declaration of export function
Date: Mon, 18 Jun 2018 10:28:03 -0700 [thread overview]
Message-ID: <20180618172803.GA8022@gmail.com> (raw)
In-Reply-To: <20180617174959.29864-1-efremov@linux.com>
On Sun, Jun 17, 2018 at 08:49:59PM +0300, efremov@linux.com wrote:
> The function skcipher_walk_next declared as static and marked as
> EXPORT_SYMBOL. It's a bit confusing since export symbol means that
> we want others to use this function. The area of visibility for such
> function is its .c file and all other modules. Other *.c files of the
> same module can't use it, despite all other modules can. Relying on
> that such behavior was not the original intention, the patch just
> removes the static keyword.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Why not remove the EXPORT_SYMBOL instead? It has no users outside the file.
- Eric
next prev parent reply other threads:[~2018-06-18 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 17:49 [PATCH] crypto: skcipher: remove static declaration of export function efremov
2018-06-18 17:28 ` Eric Biggers [this message]
2018-06-19 14:27 ` Herbert Xu
2018-06-19 20:23 ` [PATCH v2] crypto: skcipher: remove the exporting of skcipher_walk_next efremov
2018-07-01 13:19 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618172803.GA8022@gmail.com \
--to=ebiggers3@gmail.com \
--cc=davem@davemloft.net \
--cc=efremov@linux.com \
--cc=herbert@gondor.apana.org.au \
--cc=ldv-project@linuxtesting.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).