From: Eric Biggers <ebiggers3@gmail.com>
To: Juan Manuel Torres Palma <j.m.torrespalma@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
davem@davemloft.net, herbert@gondor.apana.org.au
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein
Date: Wed, 20 Jun 2018 11:10:51 -0700 [thread overview]
Message-ID: <20180620181051.GC76265@gmail.com> (raw)
In-Reply-To: <20180620105714.18359-1-j.m.torrespalma@gmail.com>
On Wed, Jun 20, 2018 at 07:57:14PM +0900, Juan Manuel Torres Palma wrote:
> Adds test vectors specified in skein v1.3
> specification. The main code is still in staging
> directory, but this is required to eventually be
> moved to the crypto directory.
Also, can you describe the users of Skein in the kernel? If there are no users,
there's no need to move it out of staging, or even have it in the kernel at all
anymore. I say that as someone who has had to volunteer to fix critical bugs
found by fuzzing in crypto algorithms for which it's unclear why they are in the
kernel at all, as there are no apparent users.
By the way, syzbot [1] doesn't have CONFIG_CRYPTO_SKEIN enabled, so the Skein
algorithms aren't being fuzzed currently.
[1] https://github.com/google/syzkaller/blob/master/docs/syzbot.md
- Eric
next prev parent reply other threads:[~2018-06-20 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 10:57 [PATCH] crypto: testmgr: add test vectors for skein Juan Manuel Torres Palma
2018-06-20 17:56 ` Eric Biggers
2018-06-20 18:26 ` Stephan Mueller
2018-06-20 18:10 ` Eric Biggers [this message]
2018-06-20 22:12 ` Juan Manuel Torres Palma
2018-06-20 23:27 ` Eric Biggers
2018-07-01 9:16 ` Herbert Xu
2018-07-01 9:47 ` Greg Kroah-Hartman
2018-07-01 16:32 ` Jason Cooper
2018-07-01 18:48 ` [PATCH] staging/skein: Remove Skein and Threefish code Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620181051.GC76265@gmail.com \
--to=ebiggers3@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=j.m.torrespalma@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).