Re: [PATCH v4 6/6] crypto: qcom: Add ACPI support

Vinod
2018-07-05T06:07:33Z

On 04-07-18, 09:46, Timur Tabi wrote:
> On 7/4/18 6:44 AM, Vinod Koul wrote:
> > + if (has_acpi_companion(&pdev->dev)) {
> > + rng->skip_init = 1;
> > + } else {
> > + rng->clk = devm_clk_get(&pdev->dev, "core");
> > + if (IS_ERR(rng->clk))
> > + return PTR_ERR(rng->clk);
> > +
> > + rng->skip_init =
> > + (unsigned long)of_device_get_match_data(&pdev->dev);
> > + }
>
> There is a device_get_match_data() function, if you want to be consistent
> between ACPI and DT.

Yes we can add driver data in ACPI ID as well so code can be:

if (!has_acpi_companion(&pdev->dev)) {
rng->clk = devm_clk_get(&pdev->dev, "core");
if (IS_ERR(rng->clk))
return PTR_ERR(rng->clk);
}
rng->skip_init = device_get_match_data(&pdev->dev);

Looks much neater.

I will wait for feedback on other patches before updating this.

Meanwhile any word from testing on ACPI systems?

Thanks
--
~Vinod