Re: [PATCH v6 13/18] wireless/lib80211: Convert from ahash to shash

Kalle Valo
2018-07-25T08:05:42Z

Johannes Berg <johannes@sipsolutions.net> writes:

> On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote:
>> In preparing to remove all stack VLA usage from the kernel[1], this
>> removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of
>> the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash
>> to direct shash. By removing a layer of indirection this both improves
>> performance and reduces stack usage. The stack allocation will be made
>> a fixed size in a later patch to the crypto subsystem.
>
> I think you sent this before - it should be in net-next now.

Yup, I see it in net-next:

d17504b16ea2 wireless/lib80211: Convert from ahash to shash

--
Kalle Valo