From: Kees Cook <keescook@chromium.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Kees Cook <keescook@chromium.org>,
Eric Biggers <ebiggers@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Arnaud Ebalard <arno@natisbad.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Christian Lamparter <chunkeey@gmail.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] crypto: Remove VLA usage from skcipher
Date: Tue, 4 Sep 2018 11:16:27 -0700 [thread overview]
Message-ID: <20180904181629.20712-1-keescook@chromium.org> (raw)
This removes VLAs[1] from SKCIPHER_REQUEST_ON_STACK by making it possible
for crypto_skcipher_set_reqsize() to fail. Callers are updated to handle
the error condition.
-Kees
[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
Kees Cook (2):
crypto: skcipher: Allow crypto_skcipher_set_reqsize() to fail
crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK
crypto/cryptd.c | 7 +++++--
crypto/ctr.c | 7 +++++--
crypto/cts.c | 7 +++++--
crypto/lrw.c | 9 ++++++---
crypto/simd.c | 7 +++++--
crypto/xts.c | 11 ++++++++---
drivers/crypto/amcc/crypto4xx_core.c | 8 +++++++-
drivers/crypto/cavium/nitrox/nitrox_algs.c | 9 +++++++--
drivers/crypto/ccree/cc_cipher.c | 6 ++++--
drivers/crypto/hisilicon/sec/sec_algs.c | 5 ++++-
drivers/crypto/inside-secure/safexcel_cipher.c | 5 ++++-
drivers/crypto/marvell/cipher.c | 4 +---
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 4 +---
include/crypto/internal/skcipher.h | 7 ++++++-
include/crypto/skcipher.h | 4 +++-
15 files changed, 71 insertions(+), 29 deletions(-)
--
2.17.1
next reply other threads:[~2018-09-04 18:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 18:16 Kees Cook [this message]
2018-09-04 18:16 ` [PATCH 1/2] crypto: skcipher: Allow crypto_skcipher_set_reqsize() to fail Kees Cook
2018-09-04 18:16 ` [PATCH 2/2] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK Kees Cook
2018-09-05 6:05 ` Alexander Stein
2018-09-05 9:18 ` Ard Biesheuvel
2018-09-05 21:05 ` Kees Cook
2018-09-05 22:49 ` Ard Biesheuvel
2018-09-06 0:43 ` Kees Cook
2018-09-06 20:22 ` Kees Cook
2018-09-06 22:23 ` Kees Cook
2018-09-06 4:53 ` Gilad Ben-Yossef
2018-09-06 7:21 ` Ard Biesheuvel
2018-09-06 8:11 ` Ard Biesheuvel
2018-09-06 8:51 ` Herbert Xu
2018-09-06 9:29 ` Ard Biesheuvel
2018-09-06 13:11 ` Herbert Xu
2018-09-06 14:49 ` Ard Biesheuvel
2018-09-06 19:18 ` Kees Cook
2018-09-06 8:25 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904181629.20712-1-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=antoine.tenart@bootlin.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arno@natisbad.org \
--cc=boris.brezillon@bootlin.com \
--cc=chunkeey@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=ebiggers@google.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=pombredanne@nexb.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox