From: Eric Biggers <ebiggers@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
nhorman@tuxdriver.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] crypto: Implement a generic crypto statistics
Date: Wed, 5 Dec 2018 16:04:59 -0800 [thread overview]
Message-ID: <20181206000458.GA209772@gmail.com> (raw)
In-Reply-To: <1537351855-16618-2-git-send-email-clabbe@baylibre.com>
Hi Corentin,
On Wed, Sep 19, 2018 at 10:10:54AM +0000, Corentin Labbe wrote:
> +int crypto_dump_reportstat(struct sk_buff *skb, struct netlink_callback *cb)
> +{
> + struct crypto_alg *alg;
> + struct crypto_dump_info info;
> + int err;
> +
> + if (cb->args[0])
> + goto out;
> +
> + cb->args[0] = 1;
> +
> + info.in_skb = cb->skb;
> + info.out_skb = skb;
> + info.nlmsg_seq = cb->nlh->nlmsg_seq;
> + info.nlmsg_flags = NLM_F_MULTI;
> +
> + list_for_each_entry(alg, &crypto_alg_list, cra_list) {
> + err = crypto_reportstat_alg(alg, &info);
> + if (err)
> + goto out_err;
> + }
> +
> +out:
> + return skb->len;
> +out_err:
> + return err;
> +}
> +
> +int crypto_dump_reportstat_done(struct netlink_callback *cb)
> +{
> + return 0;
> +}
How did you test this part? Hint: these functions are never executed.
- Eric
next prev parent reply other threads:[~2018-12-06 0:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 10:10 [PATCH v3 0/2] crypto: Implement a generic crypto statistics Corentin Labbe
2018-09-19 10:10 ` [PATCH v3 1/2] " Corentin Labbe
2018-11-03 22:19 ` Eric Biggers
2018-11-04 9:11 ` LABBE Corentin
2018-11-03 22:52 ` Eric Biggers
2018-11-04 9:12 ` LABBE Corentin
2018-12-06 0:04 ` Eric Biggers [this message]
2018-12-06 11:08 ` LABBE Corentin
2018-09-19 10:10 ` [PATCH v3 2/2] crypto: tools: Add cryptostat userspace Corentin Labbe
2018-09-28 13:13 ` Ard Biesheuvel
2018-09-28 17:03 ` Ard Biesheuvel
2018-10-01 7:20 ` LABBE Corentin
2018-10-01 8:40 ` Ard Biesheuvel
2018-09-28 5:08 ` [PATCH v3 0/2] crypto: Implement a generic crypto statistics Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206000458.GA209772@gmail.com \
--to=ebiggers@kernel.org \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).