From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Cc: Rob Rice <rob.rice@broadcom.com>,
Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Yael Chemla <yael.chemla@foss.arm.com>
Subject: [PATCH 0/3] crypto: authenc - fix key parsing
Date: Sun, 16 Dec 2018 23:23:21 -0800 [thread overview]
Message-ID: <20181217072324.16844-1-ebiggers@kernel.org> (raw)
Fix incorrect validation of the key passed to "authenc" AEADs that
allowed crashing the kernel via AF_ALG. The real fix is in patch 1, but
two drivers had to be converted to use crypto_authenc_extractkeys() too.
Please note: for the bcm and ccree driver changes I haven't re-run the
self-tests, as I don't have that hardware. Please do so if you can.
Eric Biggers (3):
crypto: authenc - fix parsing key with misaligned rta_len
crypto: bcm - convert to use crypto_authenc_extractkeys()
crypto: ccree - convert to use crypto_authenc_extractkeys()
crypto/authenc.c | 14 ++++++++---
drivers/crypto/Kconfig | 1 +
drivers/crypto/bcm/cipher.c | 44 ++++++++++------------------------
drivers/crypto/ccree/cc_aead.c | 40 +++++++++++++++----------------
4 files changed, 44 insertions(+), 55 deletions(-)
--
2.19.2
next reply other threads:[~2018-12-17 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 7:23 Eric Biggers [this message]
2018-12-17 7:23 ` [PATCH 1/3] crypto: authenc - fix parsing key with misaligned rta_len Eric Biggers
2018-12-17 7:23 ` [PATCH 2/3] crypto: bcm - convert to use crypto_authenc_extractkeys() Eric Biggers
2018-12-17 7:23 ` [PATCH 3/3] crypto: ccree " Eric Biggers
2019-01-10 14:03 ` [PATCH 0/3] crypto: authenc - fix key parsing Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217072324.16844-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=raveendra.padasalagi@broadcom.com \
--cc=rob.rice@broadcom.com \
--cc=yael.chemla@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).