* [PATCH] crypto: cavium/nitrox - Use after free in process_response_list()
@ 2019-01-04 6:46 Dan Carpenter
2019-01-10 14:05 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-01-04 6:46 UTC (permalink / raw)
To: Herbert Xu, Nagadheeraj Rottela
Cc: David S. Miller, Srikanth Jampala, Gadam Sreerama,
Nagadheeraj, Rottela, linux-crypto, kernel-janitors
We free "sr" and then dereference it on the next line.
Fixes: c9613335bf4f ("crypto: cavium/nitrox - Added AEAD cipher support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/crypto/cavium/nitrox/nitrox_reqmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/cavium/nitrox/nitrox_reqmgr.c b/drivers/crypto/cavium/nitrox/nitrox_reqmgr.c
index e34e4df8fd24..fe070d75c842 100644
--- a/drivers/crypto/cavium/nitrox/nitrox_reqmgr.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_reqmgr.c
@@ -567,10 +567,10 @@ static void process_response_list(struct nitrox_cmdq *cmdq)
/* ORH error code */
err = READ_ONCE(*sr->resp.orh) & 0xff;
- softreq_destroy(sr);
if (sr->callback)
sr->callback(sr->cb_arg, err);
+ softreq_destroy(sr);
req_completed++;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] crypto: cavium/nitrox - Use after free in process_response_list()
2019-01-04 6:46 [PATCH] crypto: cavium/nitrox - Use after free in process_response_list() Dan Carpenter
@ 2019-01-10 14:05 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-01-10 14:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nagadheeraj Rottela, David S. Miller, Srikanth Jampala,
Gadam Sreerama, Nagadheeraj, Rottela, linux-crypto,
kernel-janitors
On Fri, Jan 04, 2019 at 09:46:11AM +0300, Dan Carpenter wrote:
> We free "sr" and then dereference it on the next line.
>
> Fixes: c9613335bf4f ("crypto: cavium/nitrox - Added AEAD cipher support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/cavium/nitrox/nitrox_reqmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-10 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-04 6:46 [PATCH] crypto: cavium/nitrox - Use after free in process_response_list() Dan Carpenter
2019-01-10 14:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).