From: Eric Biggers <ebiggers@kernel.org>
To: Stephan Mueller <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 05/16] crypto: skcipher - add helper for simple block cipher modes
Date: Sun, 6 Jan 2019 13:09:52 -0800 [thread overview]
Message-ID: <20190106210951.GA1232@sol.localdomain> (raw)
In-Reply-To: <4030532.EK8pHEC8rB@tauon.chronox.de>
Hi Stephan,
On Sat, Jan 05, 2019 at 01:03:40PM +0100, Stephan Mueller wrote:
> Am Freitag, 4. Januar 2019, 05:16:14 CET schrieb Eric Biggers:
>
> Hi Eric,
>
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The majority of skcipher templates (including both the existing ones and
> > the ones remaining to be converted from the "blkcipher" API) just wrap a
> > single block cipher algorithm. This includes cbc, cfb, ctr, ecb, kw,
> > ofb, and pcbc. Add a helper function skcipher_alloc_instance_simple()
> > that handles allocating an skcipher instance for this common case.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Apart from the comment below:
>
> Reviewed-by: Stephan Mueller <smueller@chronox.de>
>
> > +struct skcipher_instance *
> > +skcipher_alloc_instance_simple(struct crypto_template *tmpl, struct rtattr
> > **tb, + struct crypto_alg **cipher_alg_ret)
> > +{
> > + struct crypto_attr_type *algt;
> > + struct crypto_alg *cipher_alg;
> > + struct skcipher_instance *inst;
> > + struct crypto_spawn *spawn;
> > + u32 mask;
> > + int err;
> > +
> > + algt = crypto_get_attr_type(tb);
> > + if (IS_ERR(algt))
> > + return ERR_CAST(algt);
> > +
> > + if ((algt->type ^ CRYPTO_ALG_TYPE_SKCIPHER) & algt->mask)
> > + return ERR_PTR(-EINVAL);
>
> Why not using crypto_check_attr_type? I understand that it does not return
> algt for the next check, but maybe we can consolidate the code a bit here?
crypto_check_attr_type() isn't a great fit because as you point out, it doesn't
return 'algt' to calculate the mask. So 'algt' would be validated twice. Also,
most templates actually do the inline check like this.
So for now I prefer to leave this as-is, and leave for later any additional
simplification of this and the other templates doing this same check. (Maybe we
could add a function that does both the type check and mask calculation.)
>
> > +
> > + mask = CRYPTO_ALG_TYPE_MASK |
> > + crypto_requires_off(algt->type, algt->mask,
> > + CRYPTO_ALG_NEED_FALLBACK);
>
>
- Eric
next prev parent reply other threads:[~2019-01-06 21:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 4:16 [PATCH 00/16] crypto: skcipher template simplifications and conversions Eric Biggers
2019-01-04 4:16 ` [PATCH 01/16] crypto: cfb - add missing 'chunksize' property Eric Biggers
[not found] ` <20190104210311.5AC542087F@mail.kernel.org>
2019-01-05 3:07 ` Eric Biggers
2019-01-05 3:40 ` Herbert Xu
2019-01-04 4:16 ` [PATCH 02/16] crypto: cfb - remove bogus memcpy() with src == dest Eric Biggers
2019-01-04 4:16 ` [PATCH 03/16] crypto: ofb - fix handling partial blocks and make thread-safe Eric Biggers
2019-01-06 10:38 ` Gilad Ben-Yossef
2019-01-04 4:16 ` [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest Eric Biggers
2019-01-04 9:57 ` David Howells
2019-01-04 17:07 ` Eric Biggers
2019-01-04 17:24 ` David Howells
2019-01-04 4:16 ` [PATCH 05/16] crypto: skcipher - add helper for simple block cipher modes Eric Biggers
2019-01-05 12:03 ` Stephan Mueller
2019-01-06 21:09 ` Eric Biggers [this message]
2019-01-04 4:16 ` [PATCH 06/16] crypto: cbc - convert to skcipher_alloc_instance_simple() Eric Biggers
2019-01-04 4:16 ` [PATCH 07/16] crypto: cfb " Eric Biggers
2019-01-04 4:16 ` [PATCH 08/16] crypto: ctr - convert to skcipher API Eric Biggers
2019-01-04 4:16 ` [PATCH 09/16] crypto: ecb " Eric Biggers
2019-01-04 4:16 ` [PATCH 10/16] crypto: keywrap " Eric Biggers
2019-01-05 11:40 ` Stephan Mueller
2019-01-04 4:16 ` [PATCH 11/16] crypto: ofb - convert to skcipher_alloc_instance_simple() Eric Biggers
2019-01-04 4:16 ` [PATCH 12/16] crypto: pcbc - remove ability to wrap internal ciphers Eric Biggers
2019-01-04 4:16 ` [PATCH 13/16] crypto: pcbc - convert to skcipher_alloc_instance_simple() Eric Biggers
2019-01-04 4:16 ` [PATCH 14/16] crypto: arc4 - convert to skcipher API Eric Biggers
2019-01-04 4:16 ` [PATCH 15/16] crypto: null - convert ecb-cipher_null " Eric Biggers
2019-01-04 4:16 ` [PATCH 16/16] crypto: algapi - remove crypto_alloc_instance() Eric Biggers
2019-01-11 6:33 ` [PATCH 00/16] crypto: skcipher template simplifications and conversions Herbert Xu
2019-01-11 17:58 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190106210951.GA1232@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).