From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A111C282D0 for ; Wed, 30 Jan 2019 03:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E03232184D for ; Wed, 30 Jan 2019 03:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548818148; bh=R0GaZ1KXQipwlylhKG51FJCcyUMVf8Sm/6cy3V6PR9o=; h=From:To:Cc:Subject:Date:List-ID:From; b=uG1/Aq3ObWrIOlBUvGw8g6efzx50tYwlxP0K7APHStVI6QGbW5r0iFQI8f4xHFPLU I4qBxGiOy01zqCeHnZogfvwaB+euNZD+HUh5DFPZ3I0Ll/N1FFQtzVaB0jjI/pW8/W qbZgc1iJdPabS2Qzu/N6anPySGs5pW72h15tMsv4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730019AbfA3DPq (ORCPT ); Tue, 29 Jan 2019 22:15:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:49986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730009AbfA3DPq (ORCPT ); Tue, 29 Jan 2019 22:15:46 -0500 Received: from sol.localdomain (c-107-3-167-184.hsd1.ca.comcast.net [107.3.167.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8098F2175B; Wed, 30 Jan 2019 03:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548818145; bh=R0GaZ1KXQipwlylhKG51FJCcyUMVf8Sm/6cy3V6PR9o=; h=From:To:Cc:Subject:Date:From; b=XYqzTkYIT47IkzNOjLARd8jp6PhmlE0Lx5u/LpKQLYhWr5VEoaN9WV7d9+pCjksm6 2MuuE+mYFBE2wRA67qOb7DKg2f+OMbaC4r810ZvZmJ1p6xTLi79qJ/x7TB3fvb+HaN b2cnT3SFAizMx8hkWr+kwDQxIsm1knLbCAgaDI4U= From: Eric Biggers To: linux-crypto@vger.kernel.org, Herbert Xu Cc: Ard Biesheuvel , Tim Chen , linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/3] crypto: crct10dif assembly cleanup and optimizations Date: Tue, 29 Jan 2019 19:14:41 -0800 Message-Id: <20190130031444.28935-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The x86, arm, and arm64 asm implementations of crct10dif are very difficult to understand partly because many of the comments, labels, and macros are named incorrectly: the lengths mentioned are usually off by a factor of two from the actual code. Many other things are unnecessarily convoluted as well, e.g. there are many more fold constants than actually needed and some aren't fully reduced. This series therefore cleans up all these implementations to be much more maintainable. I also made some small optimizations where I saw opportunities, resulting in slightly better performance. This is based on top of the pending patches from Ard Biesheuvel. These all pass the new extra self-tests. Changed since v2: - Removed the unnecessary '__LINUX_ARM_ARCH__ < 7' case. - Added Ard's Acked-by. Changed since v1: - Moved constants in arm implementation to .rodata. - Eliminated a few instructions from the x86 implementation. - Tweaked a few comments. Eric Biggers (3): crypto: x86/crct10dif-pcl - cleanup and optimizations crypto: arm/crct10dif-ce - cleanup and optimizations crypto: arm64/crct10dif-ce - cleanup and optimizations arch/arm/crypto/crct10dif-ce-core.S | 552 ++++++++-------- arch/arm/crypto/crct10dif-ce-glue.c | 2 +- arch/arm64/crypto/crct10dif-ce-core.S | 496 +++++++------- arch/arm64/crypto/crct10dif-ce-glue.c | 4 +- arch/x86/crypto/crct10dif-pcl-asm_64.S | 844 +++++++++--------------- arch/x86/crypto/crct10dif-pclmul_glue.c | 3 +- 6 files changed, 794 insertions(+), 1107 deletions(-) -- 2.20.1