linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: kbuild-all@01.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, linux-crypto@vger.kernel.org,
	netdev@vger.kernel.org, dt@chelsio.com, atul.gupta@chelsio.com
Subject: Re: [crypto 3/4] crypto/chelsio/chtls: CPL for TLS client
Date: Fri, 12 Apr 2019 12:57:40 +0800	[thread overview]
Message-ID: <201904121250.wVjn3cFV%lkp@intel.com> (raw)
In-Reply-To: <20190409152441.11256-1-atul.gupta@chelsio.com>

Hi Atul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on crypto/master]

url:    https://github.com/0day-ci/linux/commits/Atul-Gupta/Inline-TLS-client-and-v6-support/20190412-034407
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

   drivers/crypto/chelsio/chtls/chtls_cm.c:1333:42: sparse: incorrect type in assignment (different base types) @@    expected restricted __be32 [usertype] atid_status @@    got e] atid_status @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1333:42:    expected restricted __be32 [usertype] atid_status
   drivers/crypto/chelsio/chtls/chtls_cm.c:1333:42:    got int
>> drivers/crypto/chelsio/chtls/chtls_cm.c:54:6: sparse: symbol 'chtls_sock_release' was not declared. Should it be static?
   drivers/crypto/chelsio/chtls/chtls_cm.c:1155:17: sparse: expression using sizeof(void)
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1342:6: sparse: symbol 'chtls_handshake_work' was not declared. Should it be static?
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1362:6: sparse: symbol 'chtls_fix_pending_tx_buffers' was not declared. Should it be static?
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1389:23: sparse: incorrect type in argument 1 (different address spaces) @@    expected struct dst_entry *dst @@    got struct dst_entry struct dst_entry *dst @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1389:23:    expected struct dst_entry *dst
   drivers/crypto/chelsio/chtls/chtls_cm.c:1389:23:    got struct dst_entry [noderef] <asn:4>*sk_dst_cache
   drivers/crypto/chelsio/chtls/chtls_cm.c:1500:40: sparse: incorrect type in argument 1 (different address spaces) @@    expected struct socket_wq *wq @@    got struct socket_wq struct socket_wq *wq @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1500:40:    expected struct socket_wq *wq
   drivers/crypto/chelsio/chtls/chtls_cm.c:1500:40:    got struct socket_wq [noderef] <asn:4>*sk_wq
   drivers/crypto/chelsio/chtls/chtls_cm.c:1501:25: sparse: cast to restricted __poll_t
   drivers/crypto/chelsio/chtls/chtls_cm.c:1548:16: sparse: expression using sizeof(void)
   drivers/crypto/chelsio/chtls/chtls_cm.c:1698:60: sparse: Using plain integer as NULL pointer
   drivers/crypto/chelsio/chtls/chtls_cm.c:2795:39: sparse: incorrect type in argument 1 (different address spaces) @@    expected struct dst_entry *dst @@    got struct dst_entry struct dst_entry *dst @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:2795:39:    expected struct dst_entry *dst
   drivers/crypto/chelsio/chtls/chtls_cm.c:2795:39:    got struct dst_entry [noderef] <asn:4>*sk_dst_cache
   drivers/crypto/chelsio/chtls/chtls_cm.c:1801:22: sparse: context imbalance in 'chtls_recv_sock' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

      parent reply	other threads:[~2019-04-12  4:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 15:24 [crypto 3/4] crypto/chelsio/chtls: CPL for TLS client Atul Gupta
2019-04-12  4:57 ` [RFC PATCH] crypto/chelsio/chtls: chtls_sock_release() can be static kbuild test robot
2019-04-12  4:57 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201904121250.wVjn3cFV%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=atul.gupta@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=dt@chelsio.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@01.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).