* [cryptodev:master 130/163] drivers/crypto/ccree/cc_driver.c:38:6: sparse: sparse: symbol 'cc_sec_disable' was not declared. Should it be static?
@ 2019-04-26 1:03 kbuild test robot
2019-04-26 1:03 ` [RFC PATCH cryptodev] crypto: cc_sec_disable can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-04-26 1:03 UTC (permalink / raw)
To: Gilad Ben-Yossef; +Cc: kbuild-all, linux-crypto, Herbert Xu
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 1036633e10f86b793e60dd8698c65df6712cad2a
commit: f98f6e2134bd3ee5db0594dc399f9562ecc2d08a [130/163] crypto: ccree - add support for sec disabled mode
reproduce:
# apt-get install sparse
git checkout f98f6e2134bd3ee5db0594dc399f9562ecc2d08a
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/crypto/ccree/cc_driver.c:38:6: sparse: sparse: symbol 'cc_sec_disable' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread* [RFC PATCH cryptodev] crypto: cc_sec_disable can be static
2019-04-26 1:03 [cryptodev:master 130/163] drivers/crypto/ccree/cc_driver.c:38:6: sparse: sparse: symbol 'cc_sec_disable' was not declared. Should it be static? kbuild test robot
@ 2019-04-26 1:03 ` kbuild test robot
2019-04-28 7:10 ` Gilad Ben-Yossef
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-04-26 1:03 UTC (permalink / raw)
To: Gilad Ben-Yossef; +Cc: kbuild-all, linux-crypto, Herbert Xu
Fixes: f98f6e2134bd ("crypto: ccree - add support for sec disabled mode")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
cc_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
index 255d236..13b54a2 100644
--- a/drivers/crypto/ccree/cc_driver.c
+++ b/drivers/crypto/ccree/cc_driver.c
@@ -35,7 +35,7 @@ bool cc_dump_bytes;
module_param_named(dump_bytes, cc_dump_bytes, bool, 0600);
MODULE_PARM_DESC(cc_dump_bytes, "Dump buffers to kernel log as debugging aid");
-bool cc_sec_disable;
+static bool cc_sec_disable;
module_param_named(sec_disable, cc_sec_disable, bool, 0600);
MODULE_PARM_DESC(cc_sec_disable, "Disable security functions");
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-28 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-26 1:03 [cryptodev:master 130/163] drivers/crypto/ccree/cc_driver.c:38:6: sparse: sparse: symbol 'cc_sec_disable' was not declared. Should it be static? kbuild test robot
2019-04-26 1:03 ` [RFC PATCH cryptodev] crypto: cc_sec_disable can be static kbuild test robot
2019-04-28 7:10 ` Gilad Ben-Yossef
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).