From: Eric Biggers <ebiggers@kernel.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, terrelln@fb.com,
jthumshirn@suse.de
Subject: Re: [PATCH] crypto: xxhash - Implement xxhash support
Date: Mon, 27 May 2019 12:06:11 -0700 [thread overview]
Message-ID: <20190527190610.GB9394@sol.localdomain> (raw)
In-Reply-To: <20190527183932.GA9394@sol.localdomain>
On Mon, May 27, 2019 at 11:39:33AM -0700, Eric Biggers wrote:
>
> Similarly, the 'out' array might be misaligned. And conventionally the same
> bytes are output on all architectures. So I suggest:
>
> put_unaligned_u64(xxh64_digest(&ctx->xxhstate), out);
>
I meant to write put_unaligned_le64.
- Eric
next prev parent reply other threads:[~2019-05-27 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 14:28 [PATCH] crypto: xxhash - Implement xxhash support Nikolay Borisov
2019-05-27 15:06 ` Stephan Mueller
2019-05-27 19:15 ` Eric Biggers
2019-05-28 4:58 ` Stephan Mueller
2019-05-28 5:58 ` Nikolay Borisov
2019-05-28 5:59 ` Stephan Mueller
2019-05-27 19:40 ` Nikolay Borisov
2019-05-27 18:39 ` Eric Biggers
2019-05-27 19:06 ` Eric Biggers [this message]
2019-05-27 19:55 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527190610.GB9394@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jthumshirn@suse.de \
--cc=linux-crypto@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox