From: "antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>
To: Pascal Van Leeuwen <pvanleeuwen@insidesecure.com>
Cc: "antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>,
Riku Voipio <riku.voipio@linaro.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: crypto: inside_secure - call for volunteers
Date: Tue, 28 May 2019 14:45:00 +0200 [thread overview]
Message-ID: <20190528124500.GG8900@kwain> (raw)
In-Reply-To: <AM6PR09MB35237977C0E5FFB566CE3F33D21D0@AM6PR09MB3523.eurprd09.prod.outlook.com>
Hello Pascal,
On Mon, May 27, 2019 at 09:06:48PM +0000, Pascal Van Leeuwen wrote:
> > From: antoine.tenart@bootlin.com [mailto:antoine.tenart@bootlin.com]
> > - You added use of PCI helpers, but this new dependency wasn't described
> > in Kconfig (leading to have build issues).
> >
> Ah OK, to be honest, I don't know a whole lot (or much of anything, actually)
> about Kconfig, so I just hacked it a bit to be able to select the driver :-)
> But it makes sense - the PCIE subsystem is obviously always present on an
> x86 PC, so I'm getting that for free. I guess some Marvell board configs
> don't include the PCIE stuff?
PCIE support is only a configuration option, so we could have
configurations not selecting it (for whatever reason). It's not entirely
linked to the hardware having a PCIe controller or not.
> I guess the best approach would to config out the PCIE code if the
> PCIE subsystem is not configured in (instead of adding the dependency).
That would be one option.
> > - Using an EIP197 and a MacchiatoBin many of the boot tests did not
> > pass (but I haven't look into it).
> >
> Actually, if you use driver code from before yesterday with Herbert's
> crypto2.6 git tree, then the fuzzing tests would have failed.
> I originally developed directly against Linus' 5.1 tree, which apparently
> did not contain those fuzzing tests yet.
I think basic boot tests failed as well. But I'll run this again and let
you know :)
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-05-28 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 13:08 crypto: inside_secure - call for volunteers Pascal Van Leeuwen
2019-04-30 13:26 ` antoine.tenart
2019-04-30 13:41 ` Pascal Van Leeuwen
2019-04-30 13:55 ` antoine.tenart
2019-05-15 9:02 ` Pascal Van Leeuwen
2019-05-27 15:00 ` antoine.tenart
2019-05-27 21:06 ` Pascal Van Leeuwen
2019-05-28 12:45 ` antoine.tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528124500.GG8900@kwain \
--to=antoine.tenart@bootlin.com \
--cc=linux-crypto@vger.kernel.org \
--cc=pvanleeuwen@insidesecure.com \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).