From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608DEC31E46 for ; Wed, 12 Jun 2019 10:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F79120874 for ; Wed, 12 Jun 2019 10:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560336007; bh=olJE88EuGPDle+9Tm9CK1rEMk80N8UpsGxLJZzTv3x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dSYSrjRqHpANRcJL4Kz3gVLyLmqYZPmypF6T6VRJ1BbSHfb5kRVc1A8xlMRPlgpR8 ko6G9skcWGDvEhEUskhmDgj9rB2aJRKLA/nUe2t46Bah9Uv88PeFLxLXc6J31Ly4ju iRNlcjCDv+jz7ZZpmWqseHOrELE12YjOjIt54z/8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436837AbfFLKkG (ORCPT ); Wed, 12 Jun 2019 06:40:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:47910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389150AbfFLKkG (ORCPT ); Wed, 12 Jun 2019 06:40:06 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0327E2082C; Wed, 12 Jun 2019 10:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560336005; bh=olJE88EuGPDle+9Tm9CK1rEMk80N8UpsGxLJZzTv3x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rqSGJ26WhA1epEd5iGa6+JzbWjQ8AyZF8ksDozVUYo1vXzZ1K7aEeze82ZJa1JjQB BNZU7J5vrqlC3YpGiTfgCyhGB+NnChrdzCZupgVC2hVkdmJy+fipdid2cOkE1tvqt0 P40EJtFCyc0BT0Au2KyU+1wmtXHN0JS9rs7oBZWY= Date: Wed, 12 Jun 2019 18:39:27 +0800 From: Shawn Guo To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Herbert Xu , "David S. Miller" , Sascha Hauer , Rob Herring , Mark Rutland , Aymen Sghaier , Iuliana Prodan , Franck Lenormand , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx7ulp: add crypto support Message-ID: <20190612103926.GE11086@dragon> References: <20190606080255.25504-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190606080255.25504-1-horia.geanta@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 06, 2019 at 11:02:55AM +0300, Horia Geantă wrote: > From: Iuliana Prodan > > Add crypto node in device tree for CAAM support. > > Noteworthy is that on 7ulp the interrupt line is shared > between the two job rings. > > Signed-off-by: Iuliana Prodan > Signed-off-by: Franck LENORMAND > Signed-off-by: Horia Geantă > --- > > I've just realized that this patch should be merged through the crypto tree, > else bisectability could be affected due to cryptodev-2.6 > commit 385cfc84a5a8 ("crypto: caam - disable some clock checks for iMX7ULP") > ( https://patchwork.kernel.org/patch/10970017/ ) > which should come first. I'm not sure I follow it. This is a new device added to imx7ulp DT. It's never worked before on imx7ulp. How would it affect git bisect? Shawn > > arch/arm/boot/dts/imx7ulp.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi > index d6b711011cba..e20483714be5 100644 > --- a/arch/arm/boot/dts/imx7ulp.dtsi > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > @@ -100,6 +100,29 @@ > reg = <0x40000000 0x800000>; > ranges; > > + crypto: crypto@40240000 { > + compatible = "fsl,sec-v4.0"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x40240000 0x10000>; > + ranges = <0 0x40240000 0x10000>; > + clocks = <&pcc2 IMX7ULP_CLK_CAAM>, > + <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>; > + clock-names = "aclk", "ipg"; > + > + sec_jr0: jr0@1000 { > + compatible = "fsl,sec-v4.0-job-ring"; > + reg = <0x1000 0x1000>; > + interrupts = ; > + }; > + > + sec_jr1: jr1@2000 { > + compatible = "fsl,sec-v4.0-job-ring"; > + reg = <0x2000 0x1000>; > + interrupts = ; > + }; > + }; > + > lpuart4: serial@402d0000 { > compatible = "fsl,imx7ulp-lpuart"; > reg = <0x402d0000 0x1000>; > -- > 2.17.1 >