* [PATCH v3 1/4] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
@ 2019-06-12 13:33 ` David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 2/4] s390/crypto: ghash: " David Hildenbrand
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: David Hildenbrand @ 2019-06-12 13:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-s390, linux-crypto, David Hildenbrand, Herbert Xu,
David S. Miller, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Harald Freudenberger, Cornelia Huck
systemd-modules-load.service automatically tries to load the pkey module
on systems that have MSA.
Pkey also requires the MSA3 facility and a bunch of subfunctions.
Failing with -EOPNOTSUPP makes "systemd-modules-load.service" fail on
any system that does not have all needed subfunctions. For example,
when running under QEMU TCG (but also on systems where protected keys
are disabled via the HMC).
Let's use -ENODEV, so systemd-modules-load.service properly ignores
failing to load the pkey module because of missing HW functionality.
While at it, also convert the -EOPNOTSUPP in pkey_clr2protkey() to -ENODEV.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/s390/crypto/pkey_api.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c
index 45eb0c14b880..7f418d2d8cdf 100644
--- a/drivers/s390/crypto/pkey_api.c
+++ b/drivers/s390/crypto/pkey_api.c
@@ -690,7 +690,7 @@ int pkey_clr2protkey(u32 keytype,
*/
if (!cpacf_test_func(&pckmo_functions, fc)) {
DEBUG_ERR("%s pckmo functions not available\n", __func__);
- return -EOPNOTSUPP;
+ return -ENODEV;
}
/* prepare param block */
@@ -1695,15 +1695,15 @@ static int __init pkey_init(void)
* are able to work with protected keys.
*/
if (!cpacf_query(CPACF_PCKMO, &pckmo_functions))
- return -EOPNOTSUPP;
+ return -ENODEV;
/* check for kmc instructions available */
if (!cpacf_query(CPACF_KMC, &kmc_functions))
- return -EOPNOTSUPP;
+ return -ENODEV;
if (!cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_128) ||
!cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_192) ||
!cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_256))
- return -EOPNOTSUPP;
+ return -ENODEV;
pkey_debug_init();
--
2.21.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 2/4] s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 1/4] s390/pkey: " David Hildenbrand
@ 2019-06-12 13:33 ` David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 3/4] s390/crypto: prng: " David Hildenbrand
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: David Hildenbrand @ 2019-06-12 13:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-s390, linux-crypto, David Hildenbrand, Herbert Xu,
David S. Miller, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Harald Freudenberger, Cornelia Huck
Let's use the error value that is typically used if HW support is not
available when trying to load a module - this is also what systemd's
systemd-modules-load.service expects.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
arch/s390/crypto/ghash_s390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/crypto/ghash_s390.c b/arch/s390/crypto/ghash_s390.c
index 86aed30fad3a..eeeb6a7737a4 100644
--- a/arch/s390/crypto/ghash_s390.c
+++ b/arch/s390/crypto/ghash_s390.c
@@ -137,7 +137,7 @@ static struct shash_alg ghash_alg = {
static int __init ghash_mod_init(void)
{
if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_GHASH))
- return -EOPNOTSUPP;
+ return -ENODEV;
return crypto_register_shash(&ghash_alg);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 3/4] s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 1/4] s390/pkey: " David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 2/4] s390/crypto: ghash: " David Hildenbrand
@ 2019-06-12 13:33 ` David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 4/4] s390/crypto: sha: " David Hildenbrand
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: David Hildenbrand @ 2019-06-12 13:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-s390, linux-crypto, David Hildenbrand, Herbert Xu,
David S. Miller, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Harald Freudenberger, Cornelia Huck
Let's use the error value that is typically used if HW support is not
available when trying to load a module - this is also what systemd's
systemd-modules-load.service expects.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
arch/s390/crypto/prng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
index 12cca467af7d..d977643fa627 100644
--- a/arch/s390/crypto/prng.c
+++ b/arch/s390/crypto/prng.c
@@ -824,7 +824,7 @@ static int __init prng_init(void)
/* check if the CPU has a PRNG */
if (!cpacf_query_func(CPACF_KMC, CPACF_KMC_PRNG))
- return -EOPNOTSUPP;
+ return -ENODEV;
/* check if TRNG subfunction is available */
if (cpacf_query_func(CPACF_PRNO, CPACF_PRNO_TRNG))
@@ -837,7 +837,7 @@ static int __init prng_init(void)
if (prng_mode == PRNG_MODE_SHA512) {
pr_err("The prng module cannot "
"start in SHA-512 mode\n");
- return -EOPNOTSUPP;
+ return -ENODEV;
}
prng_mode = PRNG_MODE_TDES;
} else
--
2.21.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 4/4] s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
` (2 preceding siblings ...)
2019-06-12 13:33 ` [PATCH v3 3/4] s390/crypto: prng: " David Hildenbrand
@ 2019-06-12 13:33 ` David Hildenbrand
2019-06-12 13:48 ` [PATCH v3 0/4] s390/crypto: " Cornelia Huck
2019-06-12 15:08 ` Heiko Carstens
5 siblings, 0 replies; 9+ messages in thread
From: David Hildenbrand @ 2019-06-12 13:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-s390, linux-crypto, David Hildenbrand, Herbert Xu,
David S. Miller, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Harald Freudenberger, Cornelia Huck
Let's use the error value that is typically used if HW support is not
available when trying to load a module - this is also what systemd's
systemd-modules-load.service expects.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
arch/s390/crypto/sha1_s390.c | 2 +-
arch/s390/crypto/sha256_s390.c | 2 +-
arch/s390/crypto/sha512_s390.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/s390/crypto/sha1_s390.c b/arch/s390/crypto/sha1_s390.c
index 009572e8276d..7c15542d3685 100644
--- a/arch/s390/crypto/sha1_s390.c
+++ b/arch/s390/crypto/sha1_s390.c
@@ -86,7 +86,7 @@ static struct shash_alg alg = {
static int __init sha1_s390_init(void)
{
if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_1))
- return -EOPNOTSUPP;
+ return -ENODEV;
return crypto_register_shash(&alg);
}
diff --git a/arch/s390/crypto/sha256_s390.c b/arch/s390/crypto/sha256_s390.c
index 62833a1d8724..af7505148f80 100644
--- a/arch/s390/crypto/sha256_s390.c
+++ b/arch/s390/crypto/sha256_s390.c
@@ -117,7 +117,7 @@ static int __init sha256_s390_init(void)
int ret;
if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_256))
- return -EOPNOTSUPP;
+ return -ENODEV;
ret = crypto_register_shash(&sha256_alg);
if (ret < 0)
goto out;
diff --git a/arch/s390/crypto/sha512_s390.c b/arch/s390/crypto/sha512_s390.c
index be589c340d15..ad29db085a18 100644
--- a/arch/s390/crypto/sha512_s390.c
+++ b/arch/s390/crypto/sha512_s390.c
@@ -127,7 +127,7 @@ static int __init init(void)
int ret;
if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_512))
- return -EOPNOTSUPP;
+ return -ENODEV;
if ((ret = crypto_register_shash(&sha512_alg)) < 0)
goto out;
if ((ret = crypto_register_shash(&sha384_alg)) < 0)
--
2.21.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
` (3 preceding siblings ...)
2019-06-12 13:33 ` [PATCH v3 4/4] s390/crypto: sha: " David Hildenbrand
@ 2019-06-12 13:48 ` Cornelia Huck
2019-06-12 15:08 ` Heiko Carstens
5 siblings, 0 replies; 9+ messages in thread
From: Cornelia Huck @ 2019-06-12 13:48 UTC (permalink / raw)
To: David Hildenbrand
Cc: linux-kernel, linux-s390, linux-crypto, Herbert Xu,
David S. Miller, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Harald Freudenberger
On Wed, 12 Jun 2019 15:33:02 +0200
David Hildenbrand <david@redhat.com> wrote:
> s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> -ENODEV in case HW support is not available.
>
> Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> ignores this error properly.
>
> v2 -> v3:
> - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> -- Also convert pkey_clr2protkey() as requested by Harald
Looks reasonable; my r-b still stands.
> - Add r-b's (thanks!)
>
> v1 -> v2:
> - Include
> -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Harald Freudenberger <freude@linux.ibm.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
>
> David Hildenbrand (4):
> s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
>
> arch/s390/crypto/ghash_s390.c | 2 +-
> arch/s390/crypto/prng.c | 4 ++--
> arch/s390/crypto/sha1_s390.c | 2 +-
> arch/s390/crypto/sha256_s390.c | 2 +-
> arch/s390/crypto/sha512_s390.c | 2 +-
> drivers/s390/crypto/pkey_api.c | 8 ++++----
> 6 files changed, 10 insertions(+), 10 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
` (4 preceding siblings ...)
2019-06-12 13:48 ` [PATCH v3 0/4] s390/crypto: " Cornelia Huck
@ 2019-06-12 15:08 ` Heiko Carstens
2019-06-13 3:13 ` Herbert Xu
5 siblings, 1 reply; 9+ messages in thread
From: Heiko Carstens @ 2019-06-12 15:08 UTC (permalink / raw)
To: David Hildenbrand
Cc: linux-kernel, linux-s390, linux-crypto, Herbert Xu,
David S. Miller, Vasily Gorbik, Christian Borntraeger,
Harald Freudenberger, Cornelia Huck
On Wed, Jun 12, 2019 at 03:33:02PM +0200, David Hildenbrand wrote:
> s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> -ENODEV in case HW support is not available.
>
> Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> ignores this error properly.
>
> v2 -> v3:
> - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> -- Also convert pkey_clr2protkey() as requested by Harald
> - Add r-b's (thanks!)
>
> v1 -> v2:
> - Include
> -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Harald Freudenberger <freude@linux.ibm.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
>
> David Hildenbrand (4):
> s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
Should I pick these up so they can go upstream via the s390 tree?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP
2019-06-12 15:08 ` Heiko Carstens
@ 2019-06-13 3:13 ` Herbert Xu
2019-06-13 7:51 ` Heiko Carstens
0 siblings, 1 reply; 9+ messages in thread
From: Herbert Xu @ 2019-06-13 3:13 UTC (permalink / raw)
To: Heiko Carstens
Cc: David Hildenbrand, linux-kernel, linux-s390, linux-crypto,
David S. Miller, Vasily Gorbik, Christian Borntraeger,
Harald Freudenberger, Cornelia Huck
On Wed, Jun 12, 2019 at 05:08:50PM +0200, Heiko Carstens wrote:
> On Wed, Jun 12, 2019 at 03:33:02PM +0200, David Hildenbrand wrote:
> > s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> > -ENODEV in case HW support is not available.
> >
> > Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> > ignores this error properly.
> >
> > v2 -> v3:
> > - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> > -- Also convert pkey_clr2protkey() as requested by Harald
> > - Add r-b's (thanks!)
> >
> > v1 -> v2:
> > - Include
> > -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> > -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> > -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
> >
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: Vasily Gorbik <gor@linux.ibm.com>
> > Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> > Cc: Harald Freudenberger <freude@linux.ibm.com>
> > Cc: Cornelia Huck <cohuck@redhat.com>
> >
> > David Hildenbrand (4):
> > s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> > s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> > s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> > s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
>
> Should I pick these up so they can go upstream via the s390 tree?
Sure Heiko. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP
2019-06-13 3:13 ` Herbert Xu
@ 2019-06-13 7:51 ` Heiko Carstens
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Carstens @ 2019-06-13 7:51 UTC (permalink / raw)
To: Herbert Xu
Cc: David Hildenbrand, linux-kernel, linux-s390, linux-crypto,
David S. Miller, Vasily Gorbik, Christian Borntraeger,
Harald Freudenberger, Cornelia Huck
On Thu, Jun 13, 2019 at 11:13:55AM +0800, Herbert Xu wrote:
> On Wed, Jun 12, 2019 at 05:08:50PM +0200, Heiko Carstens wrote:
> > On Wed, Jun 12, 2019 at 03:33:02PM +0200, David Hildenbrand wrote:
> > > s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> > > -ENODEV in case HW support is not available.
> > >
> > > Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> > > ignores this error properly.
> > >
> > > v2 -> v3:
> > > - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> > > -- Also convert pkey_clr2protkey() as requested by Harald
> > > - Add r-b's (thanks!)
> > >
> > > v1 -> v2:
> > > - Include
> > > -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> > > -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> > > -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
> > >
> > > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > > Cc: Vasily Gorbik <gor@linux.ibm.com>
> > > Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> > > Cc: Harald Freudenberger <freude@linux.ibm.com>
> > > Cc: Cornelia Huck <cohuck@redhat.com>
> > >
> > > David Hildenbrand (4):
> > > s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> > > s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> > > s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> > > s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
> >
> > Should I pick these up so they can go upstream via the s390 tree?
>
> Sure Heiko. Thanks!
Ok, all applied. Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread