From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD67FC31E48 for ; Wed, 12 Jun 2019 13:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7D892175B for ; Wed, 12 Jun 2019 13:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436823AbfFLNsd (ORCPT ); Wed, 12 Jun 2019 09:48:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436800AbfFLNsd (ORCPT ); Wed, 12 Jun 2019 09:48:33 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 64D3D309703F; Wed, 12 Jun 2019 13:48:28 +0000 (UTC) Received: from gondolin (ovpn-116-169.ams2.redhat.com [10.36.116.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id A82841001B13; Wed, 12 Jun 2019 13:48:21 +0000 (UTC) Date: Wed, 12 Jun 2019 15:48:18 +0200 From: Cornelia Huck To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Harald Freudenberger Subject: Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP Message-ID: <20190612154818.69a02949.cohuck@redhat.com> In-Reply-To: <20190612133306.10231-1-david@redhat.com> References: <20190612133306.10231-1-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 12 Jun 2019 13:48:33 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, 12 Jun 2019 15:33:02 +0200 David Hildenbrand wrote: > s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of > -ENODEV in case HW support is not available. > > Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service > ignores this error properly. > > v2 -> v3: > - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP" > -- Also convert pkey_clr2protkey() as requested by Harald Looks reasonable; my r-b still stands. > - Add r-b's (thanks!) > > v1 -> v2: > - Include > -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP" > -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP" > -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP" > > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: Harald Freudenberger > Cc: Cornelia Huck > > David Hildenbrand (4): > s390/pkey: Use -ENODEV instead of -EOPNOTSUPP > s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP > s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP > s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP > > arch/s390/crypto/ghash_s390.c | 2 +- > arch/s390/crypto/prng.c | 4 ++-- > arch/s390/crypto/sha1_s390.c | 2 +- > arch/s390/crypto/sha256_s390.c | 2 +- > arch/s390/crypto/sha512_s390.c | 2 +- > drivers/s390/crypto/pkey_api.c | 8 ++++---- > 6 files changed, 10 insertions(+), 10 deletions(-) >