From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2FCEC31E5B for ; Tue, 18 Jun 2019 18:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 879FF206B7 for ; Tue, 18 Jun 2019 18:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560881167; bh=Mt7M1hiWtQFwHq/JT2TzGw7U6sxTiqsy7sABsh5xXvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B/BYFc0/rtu1+IS3q1olIkPVKHJx2Qds35k/OnK6eOT3foycREs/g8g4/jVTUDAom H0/KJsL+gBbgPTrIcTBUYS254FSagcMK6Z67gtxrJeTnlxKWyHhIwnAgd+qOM9TmNL /muRQhQT2H8bL5YIJE1VBlFq3V2svqNgy0rc8Za0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729319AbfFRSGH (ORCPT ); Tue, 18 Jun 2019 14:06:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:46904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727616AbfFRSGG (ORCPT ); Tue, 18 Jun 2019 14:06:06 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E282E2063F; Tue, 18 Jun 2019 18:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560881166; bh=Mt7M1hiWtQFwHq/JT2TzGw7U6sxTiqsy7sABsh5xXvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OltEX/WH5jdgnZK3v8w1kduvN71wI1G5FXhUIK4Mp90AycejE1S/M7hr+/fs+IHpC pz9GJhoAKDcrJWBvYKw9jpdLNj4VQZqCdA0h0AzO/gX0BAv9l98u16IpqCd1iAwQcm 78yJHuQIuV5gGqpgnMMr2Gii5KtSc47SxNZqZ8KU= Date: Tue, 18 Jun 2019 11:06:04 -0700 From: Eric Biggers To: Arnd Bergmann Cc: Herbert Xu , "David S. Miller" , Ard Biesheuvel , Vitaly Chikunov , Gilad Ben-Yossef , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] crypto: testmgr - dynamically allocate testvec_config Message-ID: <20190618180604.GH184520@gmail.com> References: <20190618092215.2790800-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618092215.2790800-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 18, 2019 at 11:21:52AM +0200, Arnd Bergmann wrote: > On arm32, we get warnings about high stack usage in some of the functions: > > crypto/testmgr.c:2269:12: error: stack frame size of 1032 bytes in function 'alg_test_aead' [-Werror,-Wframe-larger-than=] > static int alg_test_aead(const struct alg_test_desc *desc, const char *driver, > ^ > crypto/testmgr.c:1693:12: error: stack frame size of 1312 bytes in function '__alg_test_hash' [-Werror,-Wframe-larger-than=] > static int __alg_test_hash(const struct hash_testvec *vecs, > ^ > > On of the larger objects on the stack here is struct testvec_config, so > change that to dynamic allocation. > > Fixes: 40153b10d91c ("crypto: testmgr - fuzz AEADs against their generic implementation") > Fixes: d435e10e67be ("crypto: testmgr - fuzz skciphers against their generic implementation") > Fixes: 9a8a6b3f0950 ("crypto: testmgr - fuzz hashes against their generic implementation") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Eric Biggers - Eric