From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Pascal van Leeuwen <pascalvanl@gmail.com>
Cc: linux-crypto@vger.kernel.org, antoine.tenart@bootlin.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
Pascal van Leeuwen <pvanleeuwen@insidesecure.com>
Subject: Re: [PATCH 2/3] crypto: inside-secure - add support for PCI based FPGA development board
Date: Wed, 19 Jun 2019 14:30:50 +0200 [thread overview]
Message-ID: <20190619123050.GD3254@kwain> (raw)
In-Reply-To: <20190619121502.GA3254@kwain>
Hi Pascal,
On Wed, Jun 19, 2019 at 02:15:02PM +0200, Antoine Tenart wrote:
> On Tue, Jun 18, 2019 at 07:56:23AM +0200, Pascal van Leeuwen wrote:
>
> More generally, you should protect all the PCI specific functions and
> definitions between #ifdef.
And I think there are compilation issues if CONFIG_PCI is disabled with
this patch. This approach would probably fix it.
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-19 12:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:56 [PATCH 0/3] crypto: inside-secure - broaden driver scope Pascal van Leeuwen
2019-06-18 5:56 ` [PATCH 1/3] crypto: inside-secure - make driver selectable for non-Marvell hardware Pascal van Leeuwen
2019-06-19 12:29 ` Antoine Tenart
2019-06-18 5:56 ` [PATCH 2/3] crypto: inside-secure - add support for PCI based FPGA development board Pascal van Leeuwen
2019-06-19 12:15 ` Antoine Tenart
2019-06-19 12:30 ` Antoine Tenart [this message]
2019-06-19 14:22 ` Pascal Van Leeuwen
2019-06-20 13:06 ` Antoine Tenart
2019-06-20 14:47 ` Pascal Van Leeuwen
2019-06-20 15:36 ` Antoine Tenart
2019-06-18 5:56 ` [PATCH 3/3] crypto: inside-secure - add support for using the EIP197 without firmware images Pascal van Leeuwen
2019-06-19 12:27 ` Antoine Tenart
2019-06-19 14:37 ` Pascal Van Leeuwen
2019-06-20 13:15 ` Antoine Tenart
2019-06-20 14:59 ` Pascal Van Leeuwen
2019-06-20 15:42 ` Antoine Tenart
2019-06-24 14:20 ` Herbert Xu
2019-06-25 6:41 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619123050.GD3254@kwain \
--to=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@insidesecure.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).