From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4058DC43613 for ; Wed, 19 Jun 2019 22:37:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C4CF2166E for ; Wed, 19 Jun 2019 22:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560983835; bh=7+Xk6jM1swrTvpZVNL3BFK9YYli9gbq2RRURsP3i9Rs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PhRdjTxXzbBx2pMM8kRoqaEiXTU9PT/DArZdtBpUWBYrCuxT2r1PpQ9Eiva8qfcG3 5Y8hX+WAkp5FuIEpPDtHjq3rmC6ZwTyhrU9Jq1v6aWxWzFr7tchS4w0E7R9BzH9/oS NekRXyuNVbaPdr9cvznXyDhmf2LjwvL7KVV+XW7Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbfFSWhO (ORCPT ); Wed, 19 Jun 2019 18:37:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:47534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbfFSWhO (ORCPT ); Wed, 19 Jun 2019 18:37:14 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41C39215EA; Wed, 19 Jun 2019 22:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560983833; bh=7+Xk6jM1swrTvpZVNL3BFK9YYli9gbq2RRURsP3i9Rs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DHXGsRof2r9UQuUm4dZLiBOni5/eVdITgvyd+JYMYPVTNdcKY9XNj73BqIL7hk04t xCGAu1FHPGiAzlfHHiUQgSmT8B9trWf739BKVVktDhoLEyGTI3FMBlUMiLt/8c6tNC V3ySfHm4ThvmVAx6lYQS3Y+9t6jqnfkjk8lGPkTs= Date: Wed, 19 Jun 2019 15:37:11 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, Herbert Xu , dm-devel@redhat.com, linux-fscrypt@vger.kernel.org, Gilad Ben-Yossef , Milan Broz Subject: Re: [PATCH v3 6/6] crypto: arm64/aes - implement accelerated ESSIV/CBC mode Message-ID: <20190619223710.GC33328@gmail.com> References: <20190619162921.12509-1-ard.biesheuvel@linaro.org> <20190619162921.12509-7-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190619162921.12509-7-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jun 19, 2019 at 06:29:21PM +0200, Ard Biesheuvel wrote: > Add an accelerated version of the 'essiv(cbc(aes),aes,sha256)' > skcipher, which is used by fscrypt, and in some cases, by dm-crypt. > This avoids a separate call into the AES cipher for every invocation. > > Signed-off-by: Ard Biesheuvel I'm not sure we should bother with this, since fscrypt normally uses AES-256-XTS for contents encryption. AES-128-CBC-ESSIV support was only added because people wanted something that is fast on low-powered embedded devices with crypto accelerators such as CAAM or CESA that don't support XTS. In the case of Android, the CDD doesn't even allow AES-128-CBC-ESSIV with file-based encryption (fscrypt). It's still the default for "full disk encryption" (which uses dm-crypt), but that's being deprecated. So maybe dm-crypt users will want this, but I don't think it's very useful for fscrypt. - Eric