Re: [PATCH] crypto: inside-secure - remove unused struct entry

[Antoine Tenart <antoine.tenart@bootlin.com>]

Hello Pascal,

On Fri, Jul 05, 2019 at 10:17:25AM +0200, Pascal van Leeuwen wrote:
> This patch removes 'engines' from struct safexcel_alg_template, as it is
> no longer used.
> 
> Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
> ---
>  drivers/crypto/inside-secure/safexcel.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel.h b/drivers/crypto/inside-secure/safexcel.h
> index 379d0b0..30a222e 100644
> --- a/drivers/crypto/inside-secure/safexcel.h
> +++ b/drivers/crypto/inside-secure/safexcel.h
> @@ -660,7 +660,6 @@ struct safexcel_ahash_export_state {
>  struct safexcel_alg_template {
>  	struct safexcel_crypto_priv *priv;
>  	enum safexcel_alg_type type;
> -	u32 engines;

This patch can't be applied to the cryptodev branch, as 'engines' is
still used. I guess this is done as other (non-applied) patches are
removing the use of this member.

You should wait for either those patches to be merged (or directly
integrate this change in a newer version of those patches), or send this
patch in the same series. Otherwise it's problematic as you do not know
which patches will be applied first.

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com