From: Eric Biggers <ebiggers@kernel.org>
To: Gary R Hook <ghook@amd.com>
Cc: "Hook, Gary" <Gary.Hook@amd.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: ccp - memset structure fields to zero before reuse
Date: Tue, 9 Jul 2019 13:10:14 -0700 [thread overview]
Message-ID: <20190709201014.GH641@sol.localdomain> (raw)
In-Reply-To: <2cc5e065-0fce-5278-9c38-3bdd4755f21f@amd.com>
On Mon, Jul 08, 2019 at 05:08:09PM +0000, Gary R Hook wrote:
> On 7/5/19 2:40 PM, Eric Biggers wrote:
> > Hi Gary,
> >
> > On Wed, Jul 03, 2019 at 07:21:26PM +0000, Hook, Gary wrote:
> >> The AES GCM function reuses an 'op' data structure, which members
> >> contain values that must be cleared for each (re)use.
> >>
> >> Fixes: 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs")
> >>
> >> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> >> ---
> >> drivers/crypto/ccp/ccp-ops.c | 12 +++++++++++-
> >> 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > Is this patch meant to fix the gcm-aes-ccp self-tests failure?
>
> Yessir, that is the intention. Apologies for not clarifying that point.
>
> grh
>
>
Okay, it would be helpful if you'd explain that in the commit message.
Also, what branch does this patch apply to? It doesn't apply to cryptodev.
- Eric
next prev parent reply other threads:[~2019-07-09 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 19:21 [PATCH] crypto: ccp - memset structure fields to zero before reuse Hook, Gary
2019-07-05 19:40 ` Eric Biggers
2019-07-08 17:08 ` Gary R Hook
2019-07-09 20:10 ` Eric Biggers [this message]
2019-07-09 22:09 ` Gary R Hook
2019-07-09 22:56 ` Eric Biggers
2019-07-09 23:34 ` Gary R Hook
2019-07-10 1:47 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709201014.GH641@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Gary.Hook@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=ghook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox